[PATCH] xfstests: reiserfs, gfs2, btrfs support

[PATCH] xfstests: reiserfs, gfs2, btrfs support

[Eric Sandeen]

This patch gets reiserfs, gfs2, and btrfs off the ground.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/common.rc b/common.rc
index 54c36f3..c3e77e9 100644
--- a/common.rc
+++ b/common.rc
@@ -53,6 +53,14 @@ _mount_opts()
 	# acls & xattrs aren't turned on by default on ext$FOO
 	export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
 	;;
+    reiserfs)
+	# acls & xattrs aren't turned on by default on reiserfs
+	export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
+	;;
+    gfs2)
+	# acls aren't turned on by default on gfs2
+	export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
+	;;
     *)
 	;;
     esac
@@ -72,6 +80,12 @@ _mkfs_opts()
     nfs)
 	export MKFS_OPTIONS=$NFS_MKFS_OPTIONS
 	;;
+    reiserfs)
+	export MKFS_OPTIONS="$REISERFS_MKFS_OPTIONS -q"
+	;;
+    gfs2)
+	export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock"
+	;;
     *)
 	;;
     esac
@@ -589,7 +603,7 @@ _require_scratch()
 		     _notrun "this test requires a valid \$SCRATCH_DEV"
 		 fi
 		 ;;
-	nfs*|ext2|ext3|ext4|reiserfs)
+	nfs*|ext2|ext3|ext4|reiserfs|gfs2|btrfs)
 		 echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
 		 if [ ! -z "$SCRATCH_DEV" -a ! -b "$SCRATCH_DEV" -a "$?" != "0" ]
 		 then

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: reiserfs, gfs2, btrfs support

[Christoph Hellwig]

On Fri, May 29, 2009 at 02:27:54PM -0500, Eric Sandeen wrote:
> This patch gets reiserfs, gfs2, and btrfs off the ground.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> diff --git a/common.rc b/common.rc
> index 54c36f3..c3e77e9 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -53,6 +53,14 @@ _mount_opts()
>  	# acls & xattrs aren't turned on by default on ext$FOO
>  	export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>  	;;
> +    reiserfs)
> +	# acls & xattrs aren't turned on by default on reiserfs
> +	export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
> +	;;
> +    gfs2)
> +	# acls aren't turned on by default on gfs2
> +	export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
> +	;;

I wonder if we should find some way to auto-probe these options somehow.
It looks like lots of filesystems copied that utter braindamage from ext2 :(


Anyway the patch looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs