Re: [PATCH 6/7] xfs: use generic inode iterator in xfs_qm_dqrele_all_inodes

Eric Sandeen
2009-06-05T19:15:40Z

Christoph Hellwig wrote:

> Use xfs_inode_ag_iterator instead of opencoding the inode walk in the
> quota code. Mark xfs_inode_ag_iterator and xfs_sync_inode_valid non-static
> to allow using them from the quota code.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/quota/xfs_qm_syscalls.c
> ===================================================================
> --- xfs.orig/fs/xfs/quota/xfs_qm_syscalls.c 2009-05-13 14:52:54.087659167 +0200
> +++ xfs/fs/xfs/quota/xfs_qm_syscalls.c 2009-05-13 14:57:36.531661369 +0200

...

> + error = xfs_sync_inode_valid(ip, pag);
> + if (error)
> + return 0;

Does this need the same error propagation treatment as 5/7 ?

-Eric