Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag

Eric Sandeen
2009-05-27T20:11:41Z

Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 03:45:47PM -0500, Eric Sandeen wrote:
>> What happened to the XFS_IFLUSH_DELWRI case?
>>
>> You mentioned "keep the current behavior exactly" but this seems like a
>> change, no?
>
> Yeah, this got lost when playing with variations of the patch. Correct
> version below:
>
> Subject: xfs: split inode flushing from xfs_sync_inodes_ag
> From: Christoph Hellwig <hch@lst.de>
>
>
> In many cases we only want to sync inode metadata. Split out the inode
> flushing into a separate helper to prepare factoring the inode sync code.
>
> Based on a patch from Dave Chinner, but redone to keep the current behaviour
> exactly and leave changes to the flushing logic to another patch.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>