Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag

Christoph Hellwig
2009-05-15T17:22:39Z

On Fri, May 15, 2009 at 10:22:31AM +0530, Sujit Karataparambil wrote:
> here also should there be an
> xfs_sync_inode_data(ip, flags);
> xfs_iflush(ip, XFS_IFLUSH_SYNC);
>
> in out_unlock.

No. We only want to perform the iflush if all the preconditions are met
in the !SYNC_WAIT case. And we certainly do not want to do a data
writeout from the metadata flush case - for one thing it does require
the iolock, but most importantly the point of this series is to separate
the two actions.