From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 8/7] xfs: remove SYNC_IOWAIT
Date: Fri, 05 Jun 2009 15:37:22 -0500 [thread overview]
Message-ID: <4A298202.8080904@sandeen.net> (raw)
In-Reply-To: <20090528121915.GA30037@infradead.org>
Christoph Hellwig wrote:
> We want to wait for all I/O to finish when we do data integrity syncs. So
> there is no reason to keep SYNC_WAIT separate from SYNC_IOWAIT. This
> causes a little change in behaviour for the ENOSPC flushing code which no
> does a second submission and wait of buffered I/O, but that should finish
> ASAP as we already did an asynchronous writeout earlier.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Seems ok to me.
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfs/fs/xfs/linux-2.6/xfs_sync.c
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_sync.c 2009-05-27 12:59:57.115813662 +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_sync.c 2009-05-27 13:01:14.634816358 +0200
> @@ -226,7 +226,7 @@ xfs_sync_inode_data(
> xfs_iunlock(ip, XFS_IOLOCK_SHARED);
>
> out_wait:
> - if (flags & SYNC_IOWAIT)
> + if (flags & SYNC_WAIT)
> xfs_ioend_wait(ip);
> IRELE(ip);
> return error;
> @@ -277,7 +277,7 @@ xfs_sync_data(
> {
> int error;
>
> - ASSERT((flags & ~(SYNC_TRYLOCK|SYNC_WAIT|SYNC_IOWAIT)) == 0);
> + ASSERT((flags & ~(SYNC_TRYLOCK|SYNC_WAIT)) == 0);
>
> error = xfs_inode_ag_iterator(mp, xfs_sync_inode_data, flags, -1);
> if (error)
> @@ -419,7 +419,7 @@ xfs_quiesce_data(
> xfs_filestream_flush(mp);
>
> /* push and block */
> - xfs_sync_data(mp, SYNC_WAIT|SYNC_IOWAIT);
> + xfs_sync_data(mp, SYNC_WAIT);
> xfs_qm_sync(mp, SYNC_WAIT);
>
> /* write superblock and hoover up shutdown errors */
> @@ -532,7 +532,7 @@ xfs_flush_inodes_work(
> {
> struct inode *inode = arg;
> xfs_sync_data(mp, SYNC_TRYLOCK);
> - xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_IOWAIT);
> + xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_WAIT);
> iput(inode);
> }
>
> Index: xfs/fs/xfs/linux-2.6/xfs_sync.h
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_sync.h 2009-05-27 13:00:29.045814647 +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_sync.h 2009-05-27 13:01:39.162941539 +0200
> @@ -31,7 +31,6 @@ typedef struct xfs_sync_work {
>
> #define SYNC_WAIT 0x0004 /* wait for i/o to complete */
> #define SYNC_BDFLUSH 0x0008 /* BDFLUSH is calling -- don't block */
> -#define SYNC_IOWAIT 0x0010 /* wait for all I/O to complete */
> #define SYNC_TRYLOCK 0x0020 /* only try to lock inodes */
>
> int xfs_syncd_init(struct xfs_mount *mp);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-06-05 20:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 17:12 [PATCH 0/7] inode sync refactoring Christoph Hellwig
2009-05-14 17:12 ` [PATCH 1/7] xfs: split inode data writeback from xfs_sync_inodes_ag Christoph Hellwig
2009-05-15 4:49 ` Sujit Karataparambil
2009-05-15 17:21 ` Christoph Hellwig
2009-05-18 6:58 ` Dave Chinner
2009-05-26 20:14 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 2/7] xfs: split inode flushing " Christoph Hellwig
2009-05-15 4:52 ` Sujit Karataparambil
2009-05-15 17:22 ` Christoph Hellwig
2009-05-26 20:45 ` Eric Sandeen
2009-05-27 10:58 ` Christoph Hellwig
2009-05-27 20:11 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 3/7] xfs: factor out inode validation for sync Christoph Hellwig
2009-05-27 20:38 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 4/7] xfs: remove unused parameter from xfs_reclaim_inodes Christoph Hellwig
2009-05-27 20:44 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 5/7] xfs: introduce a per-ag inode iterator Christoph Hellwig
2009-06-03 22:01 ` Eric Sandeen
2009-06-04 11:00 ` Christoph Hellwig
2009-06-03 22:18 ` Eric Sandeen
2009-06-04 17:17 ` Christoph Hellwig
2009-06-05 18:18 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 6/7] xfs: use generic inode iterator in xfs_qm_dqrele_all_inodes Christoph Hellwig
2009-06-03 23:29 ` Josef 'Jeff' Sipek
2009-06-05 19:15 ` Eric Sandeen
2009-06-05 19:17 ` Christoph Hellwig
2009-06-05 20:11 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 7/7] xfs: split xfs_sync_inodes Christoph Hellwig
2009-06-03 23:26 ` Josef 'Jeff' Sipek
2009-06-04 10:45 ` Christoph Hellwig
2009-06-05 20:32 ` Eric Sandeen
2009-05-28 12:19 ` [PATCH 8/7] xfs: remove SYNC_IOWAIT Christoph Hellwig
2009-06-03 23:30 ` Josef 'Jeff' Sipek
2009-06-04 10:46 ` Christoph Hellwig
2009-06-05 20:37 ` Eric Sandeen [this message]
2009-05-28 12:19 ` [PATCH 9/7] xfs: remove SYNC_BDFLUSH Christoph Hellwig
2009-05-29 13:19 ` Sujit Karataparambil
2009-05-29 20:10 ` Christoph Hellwig
2009-05-30 8:27 ` Sujit Karataparambil
2009-06-05 20:45 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A298202.8080904@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox