public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Richard Kolkovich <richard@intrameta.com>
Cc: xfs@oss.sgi.com
Subject: Re: Segmentation fault during xfs_repair
Date: Sat, 06 Jun 2009 00:10:12 -0500	[thread overview]
Message-ID: <4A29FA34.5020809@sandeen.net> (raw)
In-Reply-To: <4A29F415.5020203@sandeen.net>

Eric Sandeen wrote:

> I'll have to ponder what repair should do in this case ... and I'll see
> if there's something we can do in xfs_db to just whack out this problem
> and let repair continue for now.
>
> -Eric
>
>   
This should get you over that hump I think:


--- xfsprogs-3.0.1.orig/repair/dir2.c	2009-06-06 00:01:10.711081870 -0500
+++ xfsprogs-3.0.1/repair/dir2.c	2009-06-06 00:05:52.993365954 -0500
@@ -353,6 +353,14 @@
 			}
 		}
 
+		if (i >= XFS_DA_NODE_MAXDEPTH) {
+			do_warn(_("bad header depth for directory inode %llu\n"),
+				da_cursor->ino);
+			da_brelse(bp);
+			i = -1;
+			goto error_out;
+		}
+
 		da_cursor->level[i].hashval =
 					be32_to_cpu(node->btree[0].hashval);
 		da_cursor->level[i].bp = bp;


but I have to say, that is one fried filesystem you've got there....

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-06-06  5:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05 22:22 Segmentation fault during xfs_repair Richard Kolkovich
2009-06-06  2:45 ` Eric Sandeen
2009-06-06  3:14   ` Richard Kolkovich
2009-06-06  3:25     ` Eric Sandeen
2009-06-06  4:44 ` Eric Sandeen
2009-06-06  5:10   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A29FA34.5020809@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=richard@intrameta.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox