public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs mailing list <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: Allow fsx tests to run on generic filesystems
Date: Mon, 08 Jun 2009 10:44:35 -0500	[thread overview]
Message-ID: <4A2D31E3.3090108@sandeen.net> (raw)

There is already logic in 075 to gracefully skip nfs for fsx
invocations with -x (xfs-specific preallocation) - just extend
this to any non-xfs filesystem, and add to test 112 as well.

Later we can change this behavior to use fallocate and include
more filesystems but this gets some fsx coverage for now.

Test 127 doesn't seem to have anything xfs-specific, so mark
that as generic too.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/075 b/075
index 7948c1f..49d006d 100755
--- a/075
+++ b/075
@@ -66,11 +66,11 @@ _do_test()
     echo "fsx.$_n : $_filter_param"
     echo "-----------------------------------------------"
 
-    if [ "$FSTYP" = "nfs" ]
+    if [ "$FSTYP" != "xfs" ]
     then
 	if [ "$_n" = "1" -o "$_n" = "3" ]
 	then
-	    # HACK: nfs don't handle preallocation (-x) so just skip this test
+	    # HACK: only xfs handles preallocation (-x) so just skip this test
 	    return
 	fi
     fi
@@ -124,7 +124,7 @@ _process_args()
 
 
 # real QA test starts here
-_supported_fs xfs udf nfs
+_supported_fs generic
 _supported_os IRIX Linux
 
 size10=`expr 10 \* 1024 \* 1024`	# 10 megabytes
diff --git a/112 b/112
index 70fa487..d6c2952 100755
--- a/112
+++ b/112
@@ -66,6 +66,15 @@ _do_test()
     echo "fsx.$_n : $_filter_param"
     echo "-----------------------------------------------"
 
+    if [ "$FSTYP" != "xfs" ]
+    then
+        if [ "$_n" = "1" -o "$_n" = "3" ]
+        then
+            # HACK: only xfs handles preallocation (-x) so just skip this test
+            return
+        fi
+    fi
+
     # This cd and use of -P gets full debug on $here (not TEST_DEV)
     cd $out
     if ! $here/ltp/fsx $_param -P $here $seq.$_n >/dev/null
@@ -113,7 +122,7 @@ _process_args()
 
 
 # real QA test starts here
-_supported_fs xfs
+_supported_fs generic
 _supported_os Linux
 
 [ -x $here/ltp/aio-stress ] || \
diff --git a/127 b/127
index 44db4fb..30f4fdb 100755
--- a/127
+++ b/127
@@ -103,7 +103,7 @@ _fsx_std_mmap()
 }
 
 # real QA test starts here
-_supported_fs xfs
+_supported_fs generic
 _supported_os Linux
 
 _setup_testdir


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2009-06-08 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 15:44 Eric Sandeen [this message]
2009-06-08 16:16 ` [PATCH] xfstests: Allow fsx tests to run on generic filesystems Christoph Hellwig
2009-06-08 16:26   ` Eric Sandeen
2009-06-08 22:20 ` Felix Blyakher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D31E3.3090108@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox