[PATCH] xfstests: enable test 080 for LInux

[PATCH] xfstests: enable test 080 for LInux

[Eric Sandeen]

Seems to work here...  Anyone know why it's disabled?

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/080 b/080
index e9721ad..1794a4c 100755
--- a/080
+++ b/080
@@ -48,13 +48,13 @@ _supported_fs xfs
 # Apparently should be able to work on IRIX,
 # but not at the moment.
 # It does not work on Linux due to some locking issues...
-_supported_os IRIX
+_supported_os IRIX Linux
 
 [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
 
 _setup_testdir
 
-#quiet=-q
+quiet=-q
 clean=-c
 
 export here

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: enable test 080 for LInux

[Christoph Hellwig]

On Tue, Jun 09, 2009 at 12:56:39PM -0500, Eric Sandeen wrote:
> Seems to work here...  Anyone know why it's disabled?
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> diff --git a/080 b/080
> index e9721ad..1794a4c 100755
> --- a/080
> +++ b/080
> @@ -48,13 +48,13 @@ _supported_fs xfs
>  # Apparently should be able to work on IRIX,
>  # but not at the moment.
>  # It does not work on Linux due to some locking issues...

That last line of the comment should be removed I think.

> -_supported_os IRIX
> +_supported_os IRIX Linux
>  
>  [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

Given that IRIX doesn't work we should just remove it from _supported_os
above.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: enable test 080 for LInux

[Felix Blyakher]

On Jun 9, 2009, at 12:56 PM, Eric Sandeen wrote:

> Seems to work here...  Anyone know why it's disabled?
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> diff --git a/080 b/080
> index e9721ad..1794a4c 100755
> --- a/080
> +++ b/080
> @@ -48,13 +48,13 @@ _supported_fs xfs
> # Apparently should be able to work on IRIX,
> # but not at the moment.
> # It does not work on Linux due to some locking issues...
> -_supported_os IRIX
> +_supported_os IRIX Linux
>
> [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

How do these two statements fit together. If it doesn't
work on IRIX, should we drop 'IRIX' from _supported_os ?

Felix

>
>
> _setup_testdir
>
> -#quiet=-q
> +quiet=-q
> clean=-c
>
> export here
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: enable test 080 for LInux

[Eric Sandeen]

Christoph Hellwig wrote:

> That last line of the comment should be removed I think.
>
> Given that IRIX doesn't work we should just remove it from _supported_os
> above.
>   
Heh, good points, here's the revised one:

Seems to work here...  Anyone know why it's disabled?

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/080 b/080
index e9721ad..dc51c59 100755
--- a/080
+++ b/080
@@ -47,14 +47,11 @@ _supported_fs xfs
 
 # Apparently should be able to work on IRIX,
 # but not at the moment.
-# It does not work on Linux due to some locking issues...
-_supported_os IRIX
-
-[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
+_supported_os Linux
 
 _setup_testdir
 
-#quiet=-q
+quiet=-q
 clean=-c
 
 export here

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: enable test 080 for LInux

[Felix Blyakher]

On Jun 9, 2009, at 1:32 PM, Eric Sandeen wrote:

> Christoph Hellwig wrote:
>
>> That last line of the comment should be removed I think.
>>
>> Given that IRIX doesn't work we should just remove it from  
>> _supported_os
>> above.
>>
> Heh, good points, here's the revised one:
>
> Seems to work here...  Anyone know why it's disabled?
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Reviewed-by: Felix Blyakher <felixb@sgi.com>

>
> ---
>
> diff --git a/080 b/080
> index e9721ad..dc51c59 100755
> --- a/080
> +++ b/080
> @@ -47,14 +47,11 @@ _supported_fs xfs
>
> # Apparently should be able to work on IRIX,
> # but not at the moment.
> -# It does not work on Linux due to some locking issues...
> -_supported_os IRIX
> -
> -[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
> +_supported_os Linux
>
> _setup_testdir
>
> -#quiet=-q
> +quiet=-q
> clean=-c
>
> export here
>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs