[PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs

[PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs

[Eric Sandeen]

Skip dump _cleanup if filesystem is not xfs

Many/most dump tests include common.dump before checking
supported fs, and this means that even if the dump tests
are skipped, the sleep & filesystem check in _cleanup
gets run, which makes it take rather a long time to
skip these tests for non-xfs filesystems.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---


diff --git a/common.dump b/common.dump
index 94de07f..d5aadfc 100644
--- a/common.dump
+++ b/common.dump
@@ -233,6 +233,12 @@ _wipe_fs()
 #
 _cleanup()
 {
+    # Some tests include this before checking _supported_fs xfs
+    # and the sleeps & checks get annoying
+    if [ "$FSTYP" != "xfs" ]; then
+       return
+    fi
+
     cd $here
     rm -f $tmp.*
 


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs

[Christoph Hellwig]

On Wed, Jun 10, 2009 at 12:52:11PM -0500, Eric Sandeen wrote:
> Skip dump _cleanup if filesystem is not xfs
> 
> Many/most dump tests include common.dump before checking
> supported fs, and this means that even if the dump tests
> are skipped, the sleep & filesystem check in _cleanup
> gets run, which makes it take rather a long time to
> skip these tests for non-xfs filesystems.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> 
> diff --git a/common.dump b/common.dump
> index 94de07f..d5aadfc 100644
> --- a/common.dump
> +++ b/common.dump
> @@ -233,6 +233,12 @@ _wipe_fs()
>  #
>  _cleanup()
>  {
> +    # Some tests include this before checking _supported_fs xfs
> +    # and the sleeps & checks get annoying
> +    if [ "$FSTYP" != "xfs" ]; then
> +       return
> +    fi

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs

[Felix Blyakher]

On Jun 10, 2009, at 12:52 PM, Eric Sandeen wrote:

> Skip dump _cleanup if filesystem is not xfs
>
> Many/most dump tests include common.dump before checking
> supported fs, and this means that even if the dump tests
> are skipped, the sleep & filesystem check in _cleanup
> gets run, which makes it take rather a long time to
> skip these tests for non-xfs filesystems.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Felix Blyakher <felixb@sgi.com>

>
> ---
>
>
> diff --git a/common.dump b/common.dump
> index 94de07f..d5aadfc 100644
> --- a/common.dump
> +++ b/common.dump
> @@ -233,6 +233,12 @@ _wipe_fs()
> #
> _cleanup()
> {
> +    # Some tests include this before checking _supported_fs xfs
> +    # and the sleeps & checks get annoying
> +    if [ "$FSTYP" != "xfs" ]; then
> +       return
> +    fi
> +
>     cd $here
>     rm -f $tmp.*
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs