From: Eric Sandeen <sandeen@sandeen.net>
To: xfs mailing list <xfs@oss.sgi.com>
Subject: [PATCH, RFC] default to inode64 on 64-bit systems
Date: Mon, 06 Jul 2009 13:25:34 -0500 [thread overview]
Message-ID: <4A52419E.5020301@sandeen.net> (raw)
I'm tiring of telling people to use the inode64 mount option
when they are experiencing bad performance on large xfs
filesystems...
32-bit userspace is still largely broken when it comes to still
using 32-bit stat calls, but on 64-bit systems this should be
safe.
The only problem here is moving the disk onto a 32-bit system, or using
32-bit apps. But I think it's a small risk.
What do we think about the following?
Thanks,
-Eric
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index a220d36..5d134fd 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -195,7 +195,9 @@ xfs_parseargs(
*/
mp->m_flags |= XFS_MOUNT_BARRIER;
mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
+#if BITS_PER_LONG == 32
mp->m_flags |= XFS_MOUNT_SMALL_INUMS;
+#endif
/*
* These can be overridden by the mount option parsing.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-07-06 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 18:25 Eric Sandeen [this message]
2009-07-06 18:42 ` [PATCH, RFC] default to inode64 on 64-bit systems Christoph Hellwig
2009-07-07 8:59 ` Olaf Weber
2009-07-07 10:12 ` Michael Weissenbacher
2009-07-07 9:38 ` Matthias Schniedermeyer
2009-07-07 14:06 ` Eric Sandeen
2009-07-07 18:13 ` Matthias Schniedermeyer
2009-07-07 18:17 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A52419E.5020301@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox