* [PATCH] xfstests: add tests to check log size scaling
@ 2009-07-05 19:41 Christoph Hellwig
2009-07-07 4:11 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2009-07-05 19:41 UTC (permalink / raw)
To: xfs
XFS-QA test to check that log size scaling works correctly
for old and new maximum log sizes.
[hch: split into two testcases for old "small" log scaling and the
large logs that require recent xfsprogs, and reduce the maximum
size by 1GB to make it possible to run the test on 32 bit platforms]
Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/216
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/216 2009-07-05 09:11:49.000000000 +0000
@@ -0,0 +1,79 @@
+#! /bin/sh
+# FS QA Test No. 216
+#
+# log size mkfs test - ensure the log size scaling works for small filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+# creator
+owner=dgc@sgi.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+ _cleanup_testdir
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+_setup_testdir
+_require_scratch
+_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mount
+
+_require_loop
+LOOP_DEV=$SCRATCH_MNT/test_fs
+LOOP_MNT=$SCRATCH_MNT/test_fs_dir
+
+_do_mkfs()
+{
+ for i in $*; do
+ echo -n "fssize=${i}g "
+ $MKFS_XFS_PROG -f -b size=4096 -l version=2 \
+ -d name=$LOOP_DEV,size=${i}g |grep log
+ mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
+ echo "test write" > $LOOP_MNT/test
+ umount $LOOP_MNT
+ done
+}
+# make large holey file
+$XFS_IO_PROG -f -c "truncate 256g" $LOOP_DEV
+
+#make loopback mount dir
+mkdir $LOOP_MNT
+
+# walk over standard sizes (up to 256GB)
+_do_mkfs 1 2 4 8 16 32 64 128 256
+
+status=0
+exit
Index: xfstests-dev/216.out
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/216.out 2009-07-05 09:07:36.000000000 +0000
@@ -0,0 +1,10 @@
+QA output created by 216
+fssize=1g log =internal log bsize=4096 blocks=2560, version=2
+fssize=2g log =internal log bsize=4096 blocks=2560, version=2
+fssize=4g log =internal log bsize=4096 blocks=2560, version=2
+fssize=8g log =internal log bsize=4096 blocks=2560, version=2
+fssize=16g log =internal log bsize=4096 blocks=2560, version=2
+fssize=32g log =internal log bsize=4096 blocks=4096, version=2
+fssize=64g log =internal log bsize=4096 blocks=8192, version=2
+fssize=128g log =internal log bsize=4096 blocks=16384, version=2
+fssize=256g log =internal log bsize=4096 blocks=32768, version=2
Index: xfstests-dev/group
===================================================================
--- xfstests-dev.orig/group 2009-07-04 18:07:55.000000000 +0000
+++ xfstests-dev/group 2009-07-05 09:16:04.000000000 +0000
@@ -324,3 +324,5 @@
213 rw auto prealloc quick
214 rw auto prealloc quick
215 auto metadata quick
+216 log metadata auto quick
+217 log metadata auto
Index: xfstests-dev/217
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/217 2009-07-05 09:26:57.000000000 +0000
@@ -0,0 +1,89 @@
+#! /bin/sh
+# FS QA Test No. 217
+#
+# large log size mkfs test - ensure the log size scaling works
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+# creator
+owner=dgc@sgi.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+ _cleanup_testdir
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+_setup_testdir
+_require_scratch
+_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mount
+
+_require_loop
+LOOP_DEV=$SCRATCH_MNT/test_fs
+LOOP_MNT=$SCRATCH_MNT/test_fs_dir
+
+_do_mkfs()
+{
+ for i in $*; do
+ echo -n "fssize=${i}g "
+ $MKFS_XFS_PROG -f -b size=4096 -l version=2 \
+ -d name=$LOOP_DEV,size=${i}g |grep log
+ mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
+ echo "test write" > $LOOP_MNT/test
+ umount $LOOP_MNT
+ done
+}
+# make large holey file
+$XFS_IO_PROG -f -c "truncate 16383g" $LOOP_DEV
+
+#make loopback mount dir
+mkdir $LOOP_MNT
+
+# test if large logs are supported
+$MKFS_XFS_PROG -f -l size=256m -d name=$LOOP_DEV,size=10g > /dev/null 2>&1
+if [ $? -ne 0 ]; then
+ _notrun "large log sizes not supported by mkfs"
+fi
+
+#
+# walk over "new" sizes supported by recent xfsprogs.
+# Note that the last test is for 16TB-1GB as 32bit platforms only support
+# device slightly smaller than 16TB.
+#
+_do_mkfs 512 1024 2048 4096 8192 16383
+
+status=0
+exit
Index: xfstests-dev/217.out
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/217.out 2009-07-05 09:20:17.000000000 +0000
@@ -0,0 +1,7 @@
+QA output created by 217
+fssize=512g log =internal log bsize=4096 blocks=65536, version=2
+fssize=1024g log =internal log bsize=4096 blocks=131072, version=2
+fssize=2048g log =internal log bsize=4096 blocks=262144, version=2
+fssize=4096g log =internal log bsize=4096 blocks=521728, version=2
+fssize=8192g log =internal log bsize=4096 blocks=521728, version=2
+fssize=16383g log =internal log bsize=4096 blocks=521728, version=2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfstests: add tests to check log size scaling
2009-07-05 19:41 [PATCH] xfstests: add tests to check log size scaling Christoph Hellwig
@ 2009-07-07 4:11 ` Eric Sandeen
2009-07-07 10:44 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2009-07-07 4:11 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> XFS-QA test to check that log size scaling works correctly
> for old and new maximum log sizes.
>
> [hch: split into two testcases for old "small" log scaling and the
> large logs that require recent xfsprogs, and reduce the maximum
> size by 1GB to make it possible to run the test on 32 bit platforms]
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
minor question below
>
> Index: xfstests-dev/216
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/216 2009-07-05 09:11:49.000000000 +0000
> @@ -0,0 +1,79 @@
> +#! /bin/sh
> +# FS QA Test No. 216
> +#
> +# log size mkfs test - ensure the log size scaling works for small filesystems
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=dgc@sgi.com
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> + _cleanup_testdir
> +}
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_supported_os Linux
> +
> +_setup_testdir
> +_require_scratch
> +_scratch_mkfs_xfs >/dev/null 2>&1
> +_scratch_mount
Any reason to do this on the scratch dir vs. the test dir? (Since
scratch dir became optional, I figure stuff that can go on the test dev
instead, probably should?)
not a big deal, it looks fine otherwise.
-Eric
> +_require_loop
> +LOOP_DEV=$SCRATCH_MNT/test_fs
> +LOOP_MNT=$SCRATCH_MNT/test_fs_dir
> +
> +_do_mkfs()
> +{
> + for i in $*; do
> + echo -n "fssize=${i}g "
> + $MKFS_XFS_PROG -f -b size=4096 -l version=2 \
> + -d name=$LOOP_DEV,size=${i}g |grep log
> + mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
> + echo "test write" > $LOOP_MNT/test
> + umount $LOOP_MNT
> + done
> +}
> +# make large holey file
> +$XFS_IO_PROG -f -c "truncate 256g" $LOOP_DEV
> +
> +#make loopback mount dir
> +mkdir $LOOP_MNT
> +
> +# walk over standard sizes (up to 256GB)
> +_do_mkfs 1 2 4 8 16 32 64 128 256
> +
> +status=0
> +exit
> Index: xfstests-dev/216.out
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/216.out 2009-07-05 09:07:36.000000000 +0000
> @@ -0,0 +1,10 @@
> +QA output created by 216
> +fssize=1g log =internal log bsize=4096 blocks=2560, version=2
> +fssize=2g log =internal log bsize=4096 blocks=2560, version=2
> +fssize=4g log =internal log bsize=4096 blocks=2560, version=2
> +fssize=8g log =internal log bsize=4096 blocks=2560, version=2
> +fssize=16g log =internal log bsize=4096 blocks=2560, version=2
> +fssize=32g log =internal log bsize=4096 blocks=4096, version=2
> +fssize=64g log =internal log bsize=4096 blocks=8192, version=2
> +fssize=128g log =internal log bsize=4096 blocks=16384, version=2
> +fssize=256g log =internal log bsize=4096 blocks=32768, version=2
> Index: xfstests-dev/group
> ===================================================================
> --- xfstests-dev.orig/group 2009-07-04 18:07:55.000000000 +0000
> +++ xfstests-dev/group 2009-07-05 09:16:04.000000000 +0000
> @@ -324,3 +324,5 @@
> 213 rw auto prealloc quick
> 214 rw auto prealloc quick
> 215 auto metadata quick
> +216 log metadata auto quick
> +217 log metadata auto
> Index: xfstests-dev/217
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/217 2009-07-05 09:26:57.000000000 +0000
> @@ -0,0 +1,89 @@
> +#! /bin/sh
> +# FS QA Test No. 217
> +#
> +# large log size mkfs test - ensure the log size scaling works
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=dgc@sgi.com
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> + _cleanup_testdir
> +}
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_supported_os Linux
> +
> +_setup_testdir
> +_require_scratch
> +_scratch_mkfs_xfs >/dev/null 2>&1
> +_scratch_mount
> +
> +_require_loop
> +LOOP_DEV=$SCRATCH_MNT/test_fs
> +LOOP_MNT=$SCRATCH_MNT/test_fs_dir
> +
> +_do_mkfs()
> +{
> + for i in $*; do
> + echo -n "fssize=${i}g "
> + $MKFS_XFS_PROG -f -b size=4096 -l version=2 \
> + -d name=$LOOP_DEV,size=${i}g |grep log
> + mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
> + echo "test write" > $LOOP_MNT/test
> + umount $LOOP_MNT
> + done
> +}
> +# make large holey file
> +$XFS_IO_PROG -f -c "truncate 16383g" $LOOP_DEV
> +
> +#make loopback mount dir
> +mkdir $LOOP_MNT
> +
> +# test if large logs are supported
> +$MKFS_XFS_PROG -f -l size=256m -d name=$LOOP_DEV,size=10g > /dev/null 2>&1
> +if [ $? -ne 0 ]; then
> + _notrun "large log sizes not supported by mkfs"
> +fi
> +
> +#
> +# walk over "new" sizes supported by recent xfsprogs.
> +# Note that the last test is for 16TB-1GB as 32bit platforms only support
> +# device slightly smaller than 16TB.
> +#
> +_do_mkfs 512 1024 2048 4096 8192 16383
> +
> +status=0
> +exit
> Index: xfstests-dev/217.out
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/217.out 2009-07-05 09:20:17.000000000 +0000
> @@ -0,0 +1,7 @@
> +QA output created by 217
> +fssize=512g log =internal log bsize=4096 blocks=65536, version=2
> +fssize=1024g log =internal log bsize=4096 blocks=131072, version=2
> +fssize=2048g log =internal log bsize=4096 blocks=262144, version=2
> +fssize=4096g log =internal log bsize=4096 blocks=521728, version=2
> +fssize=8192g log =internal log bsize=4096 blocks=521728, version=2
> +fssize=16383g log =internal log bsize=4096 blocks=521728, version=2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfstests: add tests to check log size scaling
2009-07-07 4:11 ` Eric Sandeen
@ 2009-07-07 10:44 ` Christoph Hellwig
2009-07-07 13:55 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2009-07-07 10:44 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, xfs
On Mon, Jul 06, 2009 at 11:11:02PM -0500, Eric Sandeen wrote:
> Any reason to do this on the scratch dir vs. the test dir? (Since
> scratch dir became optional, I figure stuff that can go on the test dev
> instead, probably should?)
>
> not a big deal, it looks fine otherwise.
The test should work just fine using the test dir, and given that these
bits all cam from Dave I can't speak for his reason to use the scratch
dir. But given that even creating an empty 16TB filesystem uses up a
lot of space I'd rather have as much as possible free space available
instead of sharing it with an aged filesystem.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests: add tests to check log size scaling
2009-07-07 10:44 ` Christoph Hellwig
@ 2009-07-07 13:55 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2009-07-07 13:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> On Mon, Jul 06, 2009 at 11:11:02PM -0500, Eric Sandeen wrote:
>> Any reason to do this on the scratch dir vs. the test dir? (Since
>> scratch dir became optional, I figure stuff that can go on the test dev
>> instead, probably should?)
>>
>> not a big deal, it looks fine otherwise.
>
> The test should work just fine using the test dir, and given that these
> bits all cam from Dave I can't speak for his reason to use the scratch
> dir. But given that even creating an empty 16TB filesystem uses up a
> lot of space I'd rather have as much as possible free space available
> instead of sharing it with an aged filesystem.
Ok, it's fine by me as posted then, consider it reviewed.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-07 13:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-05 19:41 [PATCH] xfstests: add tests to check log size scaling Christoph Hellwig
2009-07-07 4:11 ` Eric Sandeen
2009-07-07 10:44 ` Christoph Hellwig
2009-07-07 13:55 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox