* [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device
@ 2009-06-20 17:35 Christoph Hellwig
2009-07-07 10:33 ` Christoph Hellwig
2009-07-07 13:58 ` Eric Sandeen
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-06-20 17:35 UTC (permalink / raw)
To: xfs
Also clean up the way the test configuration is printed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/check
===================================================================
--- xfstests-dev.orig/check 2009-06-20 17:31:00.000000000 +0000
+++ xfstests-dev/check 2009-06-20 17:33:46.000000000 +0000
@@ -161,18 +161,15 @@
[ -f check.time ] || touch check.time
-FULL_FSTYP_DETAILS=`_full_fstyp_details`
-FULL_HOST_DETAILS=`_full_platform_details`
-FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
-FULL_MOUNT_OPTIONS=`_scratch_mount_options`
-
-cat <<EOF
-FSTYP -- $FULL_FSTYP_DETAILS
-PLATFORM -- $FULL_HOST_DETAILS
-MKFS_OPTIONS -- $FULL_MKFS_OPTIONS
-MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
+# print out our test configuration
+echo "FSTYP -- `_full_fstyp_details`"
+echo "PLATFORM -- `_full_platform_details`"
+if [ ! -z "$SCRATCH_DEV" ]; then
+ echo "MKFS_OPTIONS -- `_scratch_mkfs_options`"
+ echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
+fi
+echo
-EOF
if [ ! -z "$SCRATCH_DEV" ]; then
umount $SCRATCH_DEV 2>/dev/null
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device
2009-06-20 17:35 [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device Christoph Hellwig
@ 2009-07-07 10:33 ` Christoph Hellwig
2009-07-07 13:58 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-07-07 10:33 UTC (permalink / raw)
To: xfs
ping?
On Sat, Jun 20, 2009 at 01:35:54PM -0400, Christoph Hellwig wrote:
> Also clean up the way the test configuration is printed.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/check
> ===================================================================
> --- xfstests-dev.orig/check 2009-06-20 17:31:00.000000000 +0000
> +++ xfstests-dev/check 2009-06-20 17:33:46.000000000 +0000
> @@ -161,18 +161,15 @@
>
> [ -f check.time ] || touch check.time
>
> -FULL_FSTYP_DETAILS=`_full_fstyp_details`
> -FULL_HOST_DETAILS=`_full_platform_details`
> -FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
> -FULL_MOUNT_OPTIONS=`_scratch_mount_options`
> -
> -cat <<EOF
> -FSTYP -- $FULL_FSTYP_DETAILS
> -PLATFORM -- $FULL_HOST_DETAILS
> -MKFS_OPTIONS -- $FULL_MKFS_OPTIONS
> -MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
> +# print out our test configuration
> +echo "FSTYP -- `_full_fstyp_details`"
> +echo "PLATFORM -- `_full_platform_details`"
> +if [ ! -z "$SCRATCH_DEV" ]; then
> + echo "MKFS_OPTIONS -- `_scratch_mkfs_options`"
> + echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
> +fi
> +echo
>
> -EOF
>
> if [ ! -z "$SCRATCH_DEV" ]; then
> umount $SCRATCH_DEV 2>/dev/null
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device
2009-06-20 17:35 [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device Christoph Hellwig
2009-07-07 10:33 ` Christoph Hellwig
@ 2009-07-07 13:58 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2009-07-07 13:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> Also clean up the way the test configuration is printed.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfstests-dev/check
> ===================================================================
> --- xfstests-dev.orig/check 2009-06-20 17:31:00.000000000 +0000
> +++ xfstests-dev/check 2009-06-20 17:33:46.000000000 +0000
> @@ -161,18 +161,15 @@
>
> [ -f check.time ] || touch check.time
>
> -FULL_FSTYP_DETAILS=`_full_fstyp_details`
> -FULL_HOST_DETAILS=`_full_platform_details`
> -FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
> -FULL_MOUNT_OPTIONS=`_scratch_mount_options`
> -
> -cat <<EOF
> -FSTYP -- $FULL_FSTYP_DETAILS
> -PLATFORM -- $FULL_HOST_DETAILS
> -MKFS_OPTIONS -- $FULL_MKFS_OPTIONS
> -MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
> +# print out our test configuration
> +echo "FSTYP -- `_full_fstyp_details`"
> +echo "PLATFORM -- `_full_platform_details`"
> +if [ ! -z "$SCRATCH_DEV" ]; then
> + echo "MKFS_OPTIONS -- `_scratch_mkfs_options`"
> + echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
> +fi
> +echo
>
> -EOF
>
> if [ ! -z "$SCRATCH_DEV" ]; then
> umount $SCRATCH_DEV 2>/dev/null
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-07 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-20 17:35 [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device Christoph Hellwig
2009-07-07 10:33 ` Christoph Hellwig
2009-07-07 13:58 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox