public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Tomek Kruszona <bloodyscarion@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_repair stops on "traversing filesystem..."
Date: Fri, 10 Jul 2009 15:17:08 -0500	[thread overview]
Message-ID: <4A57A1C4.40004@sandeen.net> (raw)
In-Reply-To: <4A56ED5F.10400@gmail.com>

Tomek Kruszona wrote:
> Eric Sandeen wrote:
>> No fix for you yet, but it's in cache_node_get(), in the for(;;) loop,
>> and it looks like cache_node_allocate() fails to get a new node and we
>> keep spinning.  I need to look some more at what's going on....
> 
> Hello!
> 
> Is this specific behavior for this particular broken filesystem or is it
> a bug in functions you mentioned? I'm just curious :)

This looks like some of the caching that xfs_repair does is mis-sized,
and it gets stuck when it's unable to find a slot for a new node to
cache.  IMHO that's still a bug that I'd like to work out.  If it gets
stuck this way, it'd probably be better to exit, and suggest a larger
hash size.

But anyway, I forced a bigger hash size:

xfs_repair -P -o bhash=1024 <blah>

and it did complete.  1024 is probably over the top, but it worked for
me on a 4G machine w/ some swap.

I'd strongly suggest doing a non-obfuscated xfs_metadump, do
xfs_mdrestore of that to some temp.img, run xfs_repair <blah> on that
temp.img, mount it, and see what you're left with; that way you'll know
what you're getting into w/ repair.

I ended up w/ about 5000 files in lost+found just FWIW...

Out of curiosity, do you know how the fs was damaged?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2009-07-10 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 14:13 xfs_repair stops on "traversing filesystem..." Tomek Kruszona
2009-07-09 14:54 ` Eric Sandeen
2009-07-09 15:03   ` Tomek Kruszona
2009-07-10  5:28 ` Eric Sandeen
2009-07-10  7:27   ` Tomek Kruszona
2009-07-10 14:35     ` Eric Sandeen
2009-07-10 20:17     ` Eric Sandeen [this message]
2009-07-10 21:02       ` Tomek Kruszona
2009-07-10 21:15         ` Eric Sandeen
2009-07-10 23:44           ` Tomek Kruszona
2009-07-11  0:36             ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A57A1C4.40004@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bloodyscarion@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox