From: Eric Sandeen <sandeen@sandeen.net>
To: xfs mailing list <xfs@oss.sgi.com>
Subject: [PATCH] reduce bmv_count in xfs_vn_fiemap
Date: Wed, 15 Jul 2009 14:33:21 -0500 [thread overview]
Message-ID: <4A5E2F01.7030107@sandeen.net> (raw)
commit 6321e3ed2acf3ee9643cdd403e1c88605d7944ba caused
the full bmv_count's worth of getbmapx structures to get
allocated; telling it to do MAXEXTNUM was a bit insane,
resulting in ENOMEM.
Chop it down to something reasonable, the caller can
loop over this if the file has > 64 extents.
(this is a regression, FWIW)
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
iff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index 58973bb..370e9a7 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -680,8 +680,12 @@ xfs_vn_fiemap(
else
bm.bmv_length = BTOBB(length);
- /* our formatter will tell xfs_getbmap when to stop. */
- bm.bmv_count = MAXEXTNUM;
+ /*
+ * xfs_getbmap allocates based on that; pick a count that's
+ * not too outragous.
+ * Our formatter will tell xfs_getbmap when to stop.
+ */
+ bm.bmv_count = 64;
bm.bmv_iflags = BMV_IF_PREALLOC;
if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR)
bm.bmv_iflags |= BMV_IF_ATTRFORK;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-07-15 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 19:33 Eric Sandeen [this message]
2009-07-16 10:56 ` [PATCH] reduce bmv_count in xfs_vn_fiemap Olaf Weber
2009-07-16 14:19 ` Eric Sandeen
2009-07-16 14:48 ` [PATCH V2] " Eric Sandeen
2009-07-16 15:18 ` Olaf Weber
2009-07-16 19:11 ` [PATCH V3] " Eric Sandeen
2009-07-17 11:46 ` Olaf Weber
2009-07-18 14:25 ` Christoph Hellwig
2009-07-27 2:52 ` [PATCH V4] " Eric Sandeen
2009-07-27 7:55 ` Olaf Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5E2F01.7030107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox