From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: event tracing support
Date: Fri, 17 Jul 2009 13:40:19 -0500 [thread overview]
Message-ID: <4A60C593.1010201@sandeen.net> (raw)
In-Reply-To: <20090717180435.GA6561@infradead.org>
minor whitespace fixups for ya on top of that patch:
Index: linux-2.6.30.1/fs/xfs/linux-2.6/xfs_buf.h
===================================================================
--- linux-2.6.30.1.orig/fs/xfs/linux-2.6/xfs_buf.h
+++ linux-2.6.30.1/fs/xfs/linux-2.6/xfs_buf.h
@@ -104,7 +104,7 @@ typedef enum {
{ XBF_DELWRI, "DELWRI" }, \
{ XBF_STALE, "STALE" }, \
{ XBF_FS_MANAGED, "FS_MANAGED" }, \
- { XBF_ORDERED, "ORDERED" }, \
+ { XBF_ORDERED, "ORDERED" }, \
{ XBF_READ_AHEAD, "READ_AHEAD" }, \
{ XBF_LOCK, "LOCK" }, /* should never be set */\
{ XBF_TRYLOCK, "TRYLOCK" }, /* ditto */\
Index: linux-2.6.30.1/fs/xfs/linux-2.6/xfs_lrw.c
===================================================================
--- linux-2.6.30.1.orig/fs/xfs/linux-2.6/xfs_lrw.c
+++ linux-2.6.30.1/fs/xfs/linux-2.6/xfs_lrw.c
@@ -667,7 +667,7 @@ start:
need_i_mutex = 0;
}
- trace_xfs_rw(xip, count, *offset, ioflags, "write");
+ trace_xfs_rw(xip, count, *offset, ioflags, "write");
ret = generic_file_direct_write(iocb, iovp,
&segs, pos, offset, count, ocount);
Index: linux-2.6.30.1/fs/xfs/linux-2.6/xfs_trace.h
===================================================================
--- linux-2.6.30.1.orig/fs/xfs/linux-2.6/xfs_trace.h
+++ linux-2.6.30.1/fs/xfs/linux-2.6/xfs_trace.h
@@ -107,7 +107,7 @@ TRACE_EVENT(xfs_attr_list,
__entry->count,
__entry->firstu,
__entry->flags,
- __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS)
+ __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS)
/* we currently miss out on the per-type a13/14/15 here */
)
);
@@ -219,7 +219,7 @@ TRACE_EVENT(xfs_buf,
__entry->hold,
__entry->lockval,
__entry->val,
- (unsigned long long)__entry->file_offset,
+ (unsigned long long)__entry->file_offset,
__entry->buffer_length,
__print_flags(__entry->flags, "|", XFS_BUF_FLAGS),
(void *)__entry->caller_ip)
@@ -891,8 +891,8 @@ TRACE_EVENT(xfs_free_extent,
__entry->len,
__entry->isfl,
__entry->haveleft ?
- (__entry->haveright ? "both" : "left") :
- (__entry->haveright ? "right" : "none"))
+ (__entry->haveright ? "both" : "left") :
+ (__entry->haveright ? "right" : "none"))
);
Index: linux-2.6.30.1/fs/xfs/xfs_trans.h
===================================================================
--- linux-2.6.30.1.orig/fs/xfs/xfs_trans.h
+++ linux-2.6.30.1/fs/xfs/xfs_trans.h
@@ -138,11 +138,11 @@ typedef struct xfs_trans_header {
{ XFS_TRANS_GROWFSRT_ALLOC, "GROWFSRT_ALLOC" }, \
{ XFS_TRANS_GROWFSRT_ZERO, "GROWFSRT_ZERO" }, \
{ XFS_TRANS_GROWFSRT_FREE, "GROWFSRT_FREE" }, \
- { XFS_TRANS_SWAPEXT, "SWAPEXT" }, \
+ { XFS_TRANS_SWAPEXT, "SWAPEXT" }, \
{ XFS_TRANS_SB_COUNT, "SB_COUNT" }, \
- { XFS_TRANS_DUMMY1, "DUMMY1" }, \
- { XFS_TRANS_DUMMY2, "DUMMY2" }, \
- { XLOG_UNMOUNT_REC_TYPE, "UNMOUNT" }
+ { XFS_TRANS_DUMMY1, "DUMMY1" }, \
+ { XFS_TRANS_DUMMY2, "DUMMY2" }, \
+ { XLOG_UNMOUNT_REC_TYPE, "UNMOUNT" }
/*
* This structure is used to track log items associated with
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-17 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 21:48 [PATCH, RFC] xfs: event tracing support Christoph Hellwig
2009-06-22 18:01 ` Felix Blyakher
2009-06-22 20:59 ` Christoph Hellwig
2009-06-22 21:37 ` Felix Blyakher
2009-07-16 22:22 ` Eric Sandeen
2009-07-16 22:35 ` Steven Rostedt
2009-07-17 14:09 ` Christoph Hellwig
2009-07-17 14:50 ` [PATCH] " Christoph Hellwig
2009-07-17 18:04 ` Christoph Hellwig
2009-07-17 18:40 ` Eric Sandeen [this message]
2009-07-18 14:02 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2009-09-09 17:22 Christoph Hellwig
2009-09-14 21:40 ` Alex Elder
2009-09-19 22:21 ` Christoph Hellwig
2009-09-24 12:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A60C593.1010201@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox