From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josef Bacik <jbacik@redhat.com>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 219: test fiemap
Date: Sat, 18 Jul 2009 11:32:45 -0500 [thread overview]
Message-ID: <4A61F92D.7090708@sandeen.net> (raw)
In-Reply-To: <20090718142339.GA20905@infradead.org>
Christoph Hellwig wrote:
> On Thu, Jul 16, 2009 at 02:43:20PM -0500, Eric Sandeen wrote:
>> Preliminary fiemap testing support based on a test util
>> written by Josef Bacik.
>>
>> For now it's only run with preallocation disabled, because
>> xfs has a tendency to fill in holes with data blocks
>> (EOF prealloc stuff I think) and similar for explicit
>> preallocation, so this is breaking the preallocation
>> tests for now, when it finds a "data" block where it expects
>> a preallocated block.
>
> Wouldn't we be better off to add an fiemap command to xfs_io so that
> we can re-use it instead of having a special test program in xfstests?
I suppose it'd be nice to have, though in this case the test program
also generates all the random patterns and does the checking ... the
fiemap calls are a relatively simple part of it ...
Using xfs_io would be a bit like saying "xfs_io can already generate all
the calls that fsx generates, why not use it instead of a special test
program...." IMHO.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-18 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 19:43 [PATCH] xfstests 219: test fiemap Eric Sandeen
2009-07-18 14:23 ` Christoph Hellwig
2009-07-18 16:32 ` Eric Sandeen [this message]
2009-07-18 22:19 ` Christoph Hellwig
2009-07-27 2:48 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A61F92D.7090708@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=jbacik@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox