xfstests: nslookup not found

Christian Kujau
2009-07-19T17:57:18Z

Hi,

while trying to run ./check in a current xfstests tree, execution stopped
because "nslookup" was not available. I could've just installed this tool
but I wondered why xfstests, a filesystem testing tool, would need
nslookup at all. Turns out that it's being used in a routine called
"_get_fqdn", which in turn is only called once in ./new, to set a variable
called "owner" and I ask myself: do I really want my FQDN listed in the
testresults, that maybe even get published for analysis? I changed this
whole _get_fqdn thingy to just "uname -n", but I'm eager to know why the
FQDN is crucial here :-)

Thoughts?

Christian.

--- common.config.orig 2009-07-19 13:39:54.000000000 +0200
+++ common.config 2009-07-19 13:46:31.000000000 +0200
@@ -120,9 +120,6 @@ export UMOUNT_PROG="`set_prog_path umoun
export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`"
[ "$FSSTRESS_PROG" = "" ] && _fatal "fsstress not found"

-export NSLOOKUP_PROG="`set_prog_path nslookup`"
-[ "$NSLOOKUP_PROG" = "" ] && _fatal "nslookup not found"
-
export PERL_PROG="`set_prog_path perl`"
[ "$PERL_PROG" = "" ] && _fatal "perl not found"

--- common.rc.orig 2009-07-19 13:41:43.000000000 +0200
+++ common.rc 2009-07-19 19:44:26.000000000 +0200
@@ -330,14 +330,6 @@ _get_pids_by_name()
-e "/[0-9]:[0-9][0-9] *$1 /s/ .*//p"
}

-# fqdn for localhost
-#
-_get_fqdn()
-{
- host=`hostname`
- $NSLOOKUP_PROG $host | $AWK_PROG '{ if ($1 == "Name:") print $2 }'
-}
-
# fix malloc libs output
#
_fix_malloc()
--- new.orig 2009-07-19 19:44:52.000000000 +0200
+++ new 2009-07-19 19:46:38.000000000 +0200
@@ -105,7 +105,7 @@ cat <<End-of-File >$id
#-----------------------------------------------------------------------
#
# creator
-owner=$USER@`_get_fqdn`
+owner=$USER@`uname -n`

seq=\`basename \$0\`
echo "QA output created by \$seq"
--
BOFH excuse #4:

static from nylon underwear