public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josef Bacik <jbacik@redhat.com>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 219: test fiemap
Date: Sun, 26 Jul 2009 21:48:05 -0500	[thread overview]
Message-ID: <4A6D1565.3080307@sandeen.net> (raw)
In-Reply-To: <20090718221948.GA22347@infradead.org>

Christoph Hellwig wrote:
> On Sat, Jul 18, 2009 at 11:32:45AM -0500, Eric Sandeen wrote:
>> I suppose it'd be nice to have, though in this case the test program
>> also generates all the random patterns and does the checking ... the
>> fiemap calls are a relatively simple part of it ...
>>
>> Using xfs_io would be a bit like saying "xfs_io can already generate all
>> the calls that fsx generates, why not use it instead of a special test
>> program...." IMHO.
> 
> fiemap support in xfs_io would still be useful.  The big difference with
> fsx and co is that the I/O path is quite performance critical even for
> testcases, while for preallocation it's not.

Ok, we can add that.  Another patch.  :)

> But if it makes life a lot easier we can certainly drive these tests
> from a C program.

It's easier in the sense that it's done.  It'd be nice to get some
fiemap coverage & this is a quick route that seems to work.

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-07-27  2:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 19:43 [PATCH] xfstests 219: test fiemap Eric Sandeen
2009-07-18 14:23 ` Christoph Hellwig
2009-07-18 16:32   ` Eric Sandeen
2009-07-18 22:19     ` Christoph Hellwig
2009-07-27  2:48       ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6D1565.3080307@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=jbacik@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox