From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: actually hook up 198, make it generic
Date: Thu, 30 Jul 2009 10:38:23 -0500 [thread overview]
Message-ID: <4A71BE6F.4030609@sandeen.net> (raw)
In-Reply-To: <20090730152756.GB27914@infradead.org>
Christoph Hellwig wrote:
> On Wed, Jul 29, 2009 at 01:07:51PM -0500, Eric Sandeen wrote:
>> Not entirely sure how I managed this, but 198 was not in groups
>> so was never run - and wasn't in the makefile, so was never built.
>> Oops.
>>
>> Fix that up, make it a generic test, and move it to the
>> aio-dio-regress subdir.
>
> Hah, great one.
yeah, I rock! :/
>> # This should actually run on anything that supports O_DIRECT + AIO...
>> -_supported_fs xfs
>> +_supported_fs generic
>
> maybe also remove that comment now that it's generic.
Ok, sure.
>> --- /dev/null
>> +++ b/src/aio-dio-regress/aiodio_sparse2.c
>> @@ -0,0 +1,384 @@
>> +/* gcc -g -Wall -O2 aiodio_sparse.c -o aiodio_sparse -laio */
>> +
>> +/*
>> + * From http://developer.osdl.org/daniel/AIO/TESTS/aiodio_sparse.c
>> + * With patch from https://bugzilla.redhat.com/attachment.cgi?id=142124
>> + * (Bug https://bugzilla.redhat.com/show_bug.cgi?id=217098)
>> + */
>
> Did we manage to get a proper copyright / license statement for this
> one.
hadn't looked into it; I'll ping Daniel McNeil who seems to be the
original author ...?
But I'll fix it and worry about the copyright later, since it's already
in ...
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-30 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 18:07 [PATCH] xfstests: actually hook up 198, make it generic Eric Sandeen
2009-07-30 15:27 ` Christoph Hellwig
2009-07-30 15:38 ` Eric Sandeen [this message]
2009-07-30 16:15 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71BE6F.4030609@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox