From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix spin_is_locked assert on uni-processor builds
Date: Mon, 10 Aug 2009 09:19:33 -0500 [thread overview]
Message-ID: <4A802C75.3080904@sandeen.net> (raw)
In-Reply-To: <20090810140006.GA21521@infradead.org>
Christoph Hellwig wrote:
> Without SMP or preemption spin_is_locked always returns false,
> so we can't do an assert with it. Instead use assert_spin_locked,
> which does the right thing on all builds.
oops!
> This fixes kernel.org BZ #13621.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Johannes Engel <jcnengel@googlemail.com>
> Tested-by: Johannes Engel <jcnengel@googlemail.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
>
> Index: linux-2.6/fs/xfs/xfs_log.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/xfs_log.c 2009-08-09 23:27:07.889729629 -0300
> +++ linux-2.6/fs/xfs/xfs_log.c 2009-08-09 23:27:24.092725926 -0300
> @@ -3180,7 +3180,7 @@ try_again:
> STATIC void
> xlog_state_want_sync(xlog_t *log, xlog_in_core_t *iclog)
> {
> - ASSERT(spin_is_locked(&log->l_icloglock));
> + assert_spin_locked(&log->l_icloglock);
>
> if (iclog->ic_state == XLOG_STATE_ACTIVE) {
> xlog_state_switch_iclogs(log, iclog, 0);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-08-10 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 14:00 [PATCH] xfs: fix spin_is_locked assert on uni-processor builds Christoph Hellwig
2009-08-10 14:19 ` Eric Sandeen [this message]
2009-09-25 20:17 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A802C75.3080904@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox