From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs: remove unused scripts
Date: Wed, 09 Sep 2009 12:23:26 -0500 [thread overview]
Message-ID: <4AA7E48E.5030100@sandeen.net> (raw)
In-Reply-To: <20090902174407.GA9759@infradead.org>
Christoph Hellwig wrote:
> xfs_check64.sh and xfs_ncheck64.sh are outdated copies of xfs_check.sh
> and xfs_ncheck.sh which call a non-existant xfs_db64 binary. They
> are never installed or otherwise used, so remove them. They are
> probably a leftover from IRIX
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
OK with me, as long as sgi doesn't still have some secret xfs_db64
actually in use somewhere today that they still care about.
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfsprogs-dev/db/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/db/Makefile 2009-09-02 14:35:19.413268749 -0300
> +++ xfsprogs-dev/db/Makefile 2009-09-02 14:35:29.081614935 -0300
> @@ -15,7 +15,6 @@ HFILES = addr.h agf.h agfl.h agi.h attr.
> text.h type.h write.h attrset.h
> CFILES = $(HFILES:.h=.c)
> LSRCFILES = xfs_admin.sh xfs_check.sh xfs_ncheck.sh xfs_metadump.sh
> -LSRCFILES += xfs_check64.sh xfs_ncheck64.sh
>
> LLDLIBS = $(LIBXFS) $(LIBXLOG) $(LIBUUID) $(LIBRT) $(LIBPTHREAD)
> LTDEPENDENCIES = $(LIBXFS) $(LIBXLOG)
> Index: xfsprogs-dev/db/xfs_check64.sh
> ===================================================================
> --- xfsprogs-dev.orig/db/xfs_check64.sh 2009-09-02 14:35:39.477268924 -0300
> +++ /dev/null 1970-01-01 00:00:00.000000000 +0000
> @@ -1,36 +0,0 @@
> -#!/bin/sh -f
> -#
> -# Copyright (c) 2000-2003 Silicon Graphics, Inc. All Rights Reserved.
> -#
> -
> -OPTS=" "
> -DBOPTS=" "
> -USAGE="Usage: xfs_check64 [-fsvV] [-l logdev] [-i ino]... [-b bno]... special"
> -
> -while getopts "b:fi:l:stvV" c
> -do
> - case $c in
> - s) OPTS=$OPTS"-s ";;
> - t) OPTS=$OPTS"-t ";;
> - v) OPTS=$OPTS"-v ";;
> - V) OPTS=$OPTS"-V ";;
> - i) OPTS=$OPTS"-i "$OPTARG" ";;
> - b) OPTS=$OPTS"-b "$OPTARG" ";;
> - f) DBOPTS=" -f";;
> - l) DBOPTS=$DBOPTS" -l "$OPTARG" ";;
> - \?) echo $USAGE 1>&2
> - exit 2
> - ;;
> - esac
> -done
> -set -- extra $@
> -shift $OPTIND
> -case $# in
> - 1) xfs_db64$DBOPTS -F -i -p xfs_check64 -c "check$OPTS" $1
> - status=$?
> - ;;
> - *) echo $USAGE 1>&2
> - exit 2
> - ;;
> -esac
> -exit $status
> Index: xfsprogs-dev/db/xfs_ncheck64.sh
> ===================================================================
> --- xfsprogs-dev.orig/db/xfs_ncheck64.sh 2009-09-02 14:35:33.717268763 -0300
> +++ /dev/null 1970-01-01 00:00:00.000000000 +0000
> @@ -1,34 +0,0 @@
> -#!/bin/sh -f
> -#
> -# Copyright (c) 2000-2001 Silicon Graphics, Inc. All Rights Reserved.
> -#
> -
> -OPTS=" "
> -DBOPTS=" "
> -USAGE="usage: xfs_ncheck64 [-sfvV] [-l logdev] [-i ino]... special"
> -
> -while getopts "b:fi:l:svV" c
> -do
> - case $c in
> - s) OPTS=$OPTS"-s ";;
> - i) OPTS=$OPTS"-i "$OPTARG" ";;
> - v) OPTS=$OPTS"-v ";;
> - V) OPTS=$OPTS"-V ";;
> - f) DBOPTS=" -f";;
> - l) DBOPTS=$DBOPTS" -l "$OPTARG" ";;
> - \?) echo $USAGE 1>&2
> - exit 2
> - ;;
> - esac
> -done
> -set -- extra $@
> -shift $OPTIND
> -case $# in
> - 1) xfs_db64$DBOPTS -r -p xfs_ncheck64 -c "blockget -ns" -c "ncheck$OPTS" $1
> - status=$?
> - ;;
> - *) echo $USAGE 1>&2
> - exit 2
> - ;;
> -esac
> -exit $status
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-09-09 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 17:44 xfsprogs: remove unused scripts Christoph Hellwig
2009-09-09 17:23 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA7E48E.5030100@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox