From: "Pádraig Brady" <P@draigBrady.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org,
CoreutilsBugs <bug-coreutils@gnu.org>,
xfs@oss.sgi.com
Subject: Re: fsetxattr() fails on a writable descriptor?
Date: Wed, 09 Sep 2009 22:23:39 +0100 [thread overview]
Message-ID: <4AA81CDB.8070509@draigBrady.com> (raw)
In-Reply-To: <20090908184049.GA22050@infradead.org>
Christoph Hellwig wrote:
> On Tue, Sep 08, 2009 at 12:29:49PM +0100, P??draig Brady wrote:
>> fsetxattr() is failing for me when the permissions are readonly
>> but the descriptor is writable as demonstrated by the program below.
>> I've tried this on ext3 and ext4 with libattr-2.4.43-3.fc11.i586
>> and linux-2.6.30.5-43.fc11.i586
>
> That's not XFS specifci behaviour. For all xattr operations, fd-based
> or not we always do the full permission checks, and have done so since
> day one. Check the routined xattr_permission in fs/xattr.c of the
> kernel tree. It seems a bit unusual, but I'm not sure changing it now
> is a good idea - the xattr support has been around for a long time.
Sorry if you get this twice. Resending using another server...
Thanks for this info Christoph.
http://lxr.linux.no/#linux+v2.6.30.5/fs/xattr.c
The specific issue we have is that `cp --preserve=xattr` gets an
error when copying xattrs from a read only file. Since this has been
an xattr issue since the start, we'll have to work around it.
We'll probably temporarily set u+w on the new file to apply xattrs.
cheers,
Pádraig.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-09-09 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1251987642.3855.36.camel@dhcp-lab-219.englab.brq.redhat.com>
[not found] ` <4AA1A3E6.2020606@draigBrady.com>
[not found] ` <87k50den1e.fsf@meyering.net>
[not found] ` <1252309787.3852.8.camel@dhcp-lab-219.englab.brq.redhat.com>
[not found] ` <4AA4C950.3080303@draigBrady.com>
[not found] ` <1252318482.3852.18.camel@dhcp-lab-219.englab.brq.redhat.com>
2009-09-08 11:29 ` fsetxattr() fails on a writable descriptor? Pádraig Brady
2009-09-08 18:40 ` Christoph Hellwig
2009-09-09 21:23 ` Pádraig Brady [this message]
2009-09-09 22:14 ` Michael Monnerie
2009-10-13 23:58 ` Christoph Hellwig
2009-10-14 1:17 ` Michael Monnerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA81CDB.8070509@draigBrady.com \
--to=p@draigbrady.com \
--cc=bug-coreutils@gnu.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox