From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n965qbZn023800 for ; Tue, 6 Oct 2009 00:52:42 -0500 Received: from hera.kernel.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 29CD4BD5098 for ; Mon, 5 Oct 2009 22:54:01 -0700 (PDT) Received: from hera.kernel.org (hera.kernel.org [140.211.167.34]) by cuda.sgi.com with ESMTP id OC9ieUl2X6OmaZEJ for ; Mon, 05 Oct 2009 22:54:01 -0700 (PDT) Message-ID: <4ACADB74.5090508@kernel.org> Date: Tue, 06 Oct 2009 14:53:56 +0900 From: Tejun Heo MIME-Version: 1.0 Subject: Re: stack bloat after stackprotector changes References: <4ACA5EB0.4010707@sandeen.net> In-Reply-To: <4ACA5EB0.4010707@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs mailing list Eric Sandeen wrote: > It seems that after: > > commit 5d707e9c8ef2a3596ed5c975c6ff05cec890c2b4 > Author: Tejun Heo > Date: Mon Feb 9 22:17:39 2009 +0900 > > stackprotector: update make rules > > xfs stack usage jumped up a fair bit; > > Not a lot in each case but could be significant as it accumulates. > > I'm not familiar w/ the gcc stack protector feature; would this be an > expected result? Yeah, it adds a bit of stack usage per each function call and around arrays which seem like they could overflow, so the behavior is expected and I can see it can be a problem with function call depth that deep. Has it caused actual stack overflow? Thanks. -- tejun _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs