From: Eric Sandeen <sandeen@sandeen.net>
To: Nathan Scott <nscott@aconex.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] mkfs: add discard support
Date: Tue, 06 Oct 2009 22:55:48 -0500 [thread overview]
Message-ID: <4ACC1144.5090504@sandeen.net> (raw)
In-Reply-To: <1157959921.9631254878431584.JavaMail.root@mail-au.aconex.com>
Nathan Scott wrote:
> ----- "Christoph Hellwig" <hch@infradead.org> wrote:
>
>>> It might be a bit cleaner to add this in with the existing
>> platform-
>>> specific code in libxfs/linux.c (or perhaps
>> include/platform_defs.h)
>>> with wrappers for the other platforms, rather than putting it
>> directly
>>> in mkfs like this? repair may want to use this someday too, I
>> guess.
>>
>> How about this one?
>>
>
> Looks good to me.
>
> cheers.
>
looks good to me too, thanks.
need to get that vertex flashed w/ trim support some day...
-eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-07 3:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1235789111.21721254856913943.JavaMail.root@mail-au.aconex.com>
2009-10-06 19:24 ` [PATCH] mkfs: add discard support Nathan Scott
2009-10-06 19:26 ` Christoph Hellwig
2009-10-07 1:18 ` Christoph Hellwig
2009-10-07 1:20 ` Nathan Scott
2009-10-07 3:55 ` Eric Sandeen [this message]
2009-11-12 16:04 ` Christoph Hellwig
2009-10-06 18:47 Christoph Hellwig
2009-10-07 4:42 ` Dave Chinner
2009-10-07 6:05 ` Michael Monnerie
2009-10-07 14:11 ` Christoph Hellwig
2009-10-07 20:24 ` Andi Kleen
2009-10-09 2:30 ` Dave Chinner
2009-10-10 4:22 ` Andi Kleen
2009-10-10 16:24 ` Christoph Hellwig
2009-10-12 1:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACC1144.5090504@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox