Re: [PATCH 04/14] repair: split up scanfunc_ino

Eric Sandeen
2009-10-13T22:21:11Z

Christoph Hellwig wrote:
> On Mon, Oct 12, 2009 at 03:06:40PM -0500, Eric Sandeen wrote:
>>> + agno, agbno,
>>> + mp->m_sb.sb_inopblock);
>> pretty weird indentation here can't you just merge w/ previous line?

I get that...

+_("inode chunk claims used block, inobt block - agno %d, bno %d, inopb
%d\n"),
+ agno, agbno,
+ mp->m_sb.sb_inopblock);

the unindented string is fine but the 3rd line in the paste above
could/should be merged w/ the 2nd.

-Eric

> XFS (especially userspace code) uses this in lots of places. Gives
> more space to messages but keeps the normal arguments normally aligned.
>
>> Also is the change from bno to agbno intentional in the message?
>> I guess it's fine.
>
> That version is more correct. Don't remember how it got in, though.