From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/14] repair: kill B_IS_META flag
Date: Mon, 12 Oct 2009 14:45:08 -0500 [thread overview]
Message-ID: <4AD38744.3010702@sandeen.net> (raw)
In-Reply-To: <20090902175840.224768080@bombadil.infradead.org>
Christoph Hellwig wrote:
> B_IS_META is the inverse flag of B_IS_INODE which is not really obvious
> from it's use. So just use !B_IS_INODE to make it more clear.
>
Logic-wise it's fine, but is this change really helpful? The comment says:
/*
* Test if bit 0 or 2 is set in the "priority tag" of the buffer to see if
* the buffer is for an inode or other metadata.
*/
so basically it distinguishes inodes from other metadata right.
!B_IS_INODE() seems less than helpful...
B_IS_INODE is clear; B_IS_META is pretty clear, "!B_IS_INODE" seems muddy; so
very many things are "not inodes" :)
-Eric
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/repair/prefetch.c
> ===================================================================
> --- xfsprogs-dev.orig/repair/prefetch.c 2009-08-20 00:02:25.000000000 +0000
> +++ xfsprogs-dev/repair/prefetch.c 2009-08-20 00:05:36.000000000 +0000
> @@ -64,7 +64,6 @@
> * the buffer is for an inode or other metadata.
> */
> #define B_IS_INODE(f) (((f) & 5) == 0)
> -#define B_IS_META(f) (((f) & 5) != 0)
>
> #define DEF_BATCH_BYTES 0x10000
>
> @@ -131,7 +130,7 @@
>
> if (fsbno > args->last_bno_read) {
> radix_tree_insert(&args->primary_io_queue, fsbno, bp);
> - if (B_IS_META(flag))
> + if (!B_IS_INODE(flag))
> radix_tree_tag_set(&args->primary_io_queue, fsbno, 0);
> else {
> args->inode_bufs_queued++;
> @@ -153,7 +152,7 @@
> (long long)XFS_BUF_ADDR(bp), args->agno, fsbno,
> args->last_bno_read);
> #endif
> - ASSERT(B_IS_META(flag));
> + ASSERT(!B_IS_INODE(flag));
> XFS_BUF_SET_PRIORITY(bp, B_DIR_META_2);
> radix_tree_insert(&args->secondary_io_queue, fsbno, bp);
> }
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-12 19:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 17:55 [PATCH 00/14] repair memory usage reductions Christoph Hellwig
2009-09-02 17:55 ` [PATCH 01/14] repair: merge scanfunc_bno and scanfunc_cnt Christoph Hellwig
2009-10-12 16:53 ` Eric Sandeen
2009-10-13 22:13 ` Christoph Hellwig
2009-10-13 23:36 ` Alex Elder
2009-09-02 17:55 ` [PATCH 02/14] repair: reduce byte swap operations in scanfunc_allocbt Christoph Hellwig
2009-10-12 17:18 ` Eric Sandeen
2009-10-13 23:37 ` [PATCH 02/14] repair: reduce byte swap operations inscanfunc_allocbt Alex Elder
2009-09-02 17:55 ` [PATCH 03/14] repair: kill B_IS_META flag Christoph Hellwig
2009-10-12 19:45 ` Eric Sandeen [this message]
2009-10-13 22:16 ` Christoph Hellwig
2009-10-13 22:19 ` Eric Sandeen
2009-10-13 23:38 ` Alex Elder
2009-09-02 17:55 ` [PATCH 04/14] repair: split up scanfunc_ino Christoph Hellwig
2009-10-12 20:06 ` Eric Sandeen
2009-10-13 22:19 ` Christoph Hellwig
2009-10-13 22:22 ` Eric Sandeen
2009-10-13 22:23 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 05/14] repair: reduce byte swapping in scan_freelist Christoph Hellwig
2009-10-12 20:43 ` Eric Sandeen
2009-09-02 17:55 ` [PATCH 06/14] repair: use a btree instead of a radix tree for the prefetch queue Christoph Hellwig
2009-10-21 17:12 ` [PATCH 06/14] repair: use a btree instead of a radix tree for theprefetch queue Alex Elder
2009-11-12 10:04 ` Christoph Hellwig
2009-11-12 23:46 ` Dave Chinner
2009-09-02 17:55 ` [PATCH 07/14] repair: use single prefetch queue Christoph Hellwig
2009-10-21 17:48 ` Alex Elder
2009-11-12 10:09 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 08/14] repair: clean up prefetch tracing Christoph Hellwig
2009-10-21 17:53 ` Alex Elder
2009-09-02 17:55 ` [PATCH 09/14] repair: track logical to physical block mapping more effeciently Christoph Hellwig
2009-10-21 19:06 ` [PATCH 09/14] repair: track logical to physical block mapping moreeffeciently Alex Elder
2009-11-12 10:18 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 10/14] repair: cleanup helpers for tracking block usage Christoph Hellwig
2009-10-21 19:33 ` Alex Elder
2009-11-12 10:21 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 11/14] repair: cleanup alloc/free/reset of the block usage tracking Christoph Hellwig
2009-10-21 20:22 ` [PATCH 11/14] repair: cleanup alloc/free/reset of the block usagetracking Alex Elder
2009-09-02 17:55 ` [PATCH 12/14] repair: switch block usage bitmap to a btree Christoph Hellwig
2009-10-22 16:22 ` Alex Elder
2009-11-12 10:25 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 13/14] repair: optimize duplicate extent tracking Christoph Hellwig
2009-10-22 16:41 ` Alex Elder
2009-09-02 17:55 ` [PATCH 14/14] repair: add missing locking in scanfunc_bmap Christoph Hellwig
2009-10-22 16:42 ` Alex Elder
2009-09-03 20:49 ` [PATCH 00/14] repair memory usage reductions Geoffrey Wehrman
2009-09-04 2:57 ` Dave Chinner
2009-09-04 13:37 ` Geoffrey Wehrman
2009-09-04 14:51 ` Christoph Hellwig
2009-09-04 17:24 ` Michael Monnerie
2009-11-12 15:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD38744.3010702@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox