From: Eric Sandeen <sandeen@sandeen.net>
To: Nathan Scott <nscott@aconex.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
Date: Mon, 12 Oct 2009 19:29:51 -0500 [thread overview]
Message-ID: <4AD3C9FF.7010307@sandeen.net> (raw)
In-Reply-To: <1205635767.11581255391391231.JavaMail.root@mail-au.aconex.com>
Nathan Scott wrote:
> ----- "Christoph Hellwig" <hch@infradead.org> wrote:
>
>> Currently the build/ directory can create rpm, debian and source /
>> binary
>> tar packages. The RPM generation is not used as all distributions
>> prefer,
>> their own spec files, and the binary tarball not used at all as it's
>> a not very useful format. Reimplement the generation of the source
>> tarballs to use the source-link method used for the debian packages
>> and
>> get rid of the whole old package generation machinery. Also fix a
>> small
>> bug in the link-based source directory creation which was not
>> including
>> the .pot file for gettext.
>
> From looking through the patch it seems OK to me. I haven't had a chance
> to test it out yet, though - but from just eyeballing it, and if noone
> pipes up complaining about the auto-rpm-build removal (I don't expect
> they will, at this stage of xfsprogs life) it all looks good and correct.
>
> cheers.
>
die rpmbuild die ;)
Long as building tarballs works I'm happy.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-13 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 2:45 [PATCH] xfsprogs: simplify and unify source package generation Christoph Hellwig
2009-10-12 23:49 ` Nathan Scott
2009-10-13 0:29 ` Eric Sandeen [this message]
2009-10-25 7:47 ` Christoph Hellwig
2009-10-25 22:36 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD3C9FF.7010307@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox