From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	n9DMLBbo156944 for <xfs@oss.sgi.com>; Tue, 13 Oct 2009 17:21:11 -0500
Received: from mx1.redhat.com (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 60584C2649E
	for <xfs@oss.sgi.com>; Tue, 13 Oct 2009 15:22:41 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
	cuda.sgi.com with ESMTP id WbfQGFguZCJuabAA for
	<xfs@oss.sgi.com>; Tue, 13 Oct 2009 15:22:41 -0700 (PDT)
Message-ID: <4AD4FDA8.6060705@sandeen.net>
Date: Tue, 13 Oct 2009 17:22:32 -0500
From: Eric Sandeen <sandeen@sandeen.net>
MIME-Version: 1.0
Subject: Re: [PATCH 04/14] repair: split up scanfunc_ino
References: <20090902175531.469184575@bombadil.infradead.org>
	<20090902175840.403232401@bombadil.infradead.org>
	<4AD38C50.2060403@sandeen.net>
	<20091013221946.GB31385@infradead.org>
In-Reply-To: <20091013221946.GB31385@infradead.org>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com

Christoph Hellwig wrote:
> On Mon, Oct 12, 2009 at 03:06:40PM -0500, Eric Sandeen wrote:
>>> +					agno, agbno,
>>> +				mp->m_sb.sb_inopblock);
>> pretty weird indentation here can't you just merge w/ previous line?

I get that...


+_("inode chunk claims used block, inobt block - agno %d, bno %d, inopb
%d\n"),
+					agno, agbno,
+				mp->m_sb.sb_inopblock);

the unindented string is fine but the 3rd line in the paste above
could/should be merged w/ the 2nd.

-Eric


> XFS (especially userspace code) uses this in lots of places.  Gives
> more space to messages but keeps the normal arguments normally aligned.
> 
>> Also is the change from bno to agbno intentional in the message?
>> I guess it's fine.
> 
> That version is more correct.  Don't remember how it got in, though.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs