public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill Kendall <wkendall@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks
Date: Tue, 27 Oct 2009 10:36:04 -0500	[thread overview]
Message-ID: <4AE71364.7090102@sgi.com> (raw)
In-Reply-To: <20091025070544.GA21462@infradead.org>

On 10/25/2009 02:05 AM, Christoph Hellwig wrote:
> On Thu, Oct 22, 2009 at 11:52:32AM -0500, Bill Kendall wrote:
>> Update xfsrestore to use the new lpath_to_handle function
>> when dealing with symlinks.
> 
> Requiring a simultanously released version of xfsprogs is a very bad
> idea.  The right fix is to add an autoconf check for the new function
> and use it when available, falling back to the inferior old version
> if it is not available.

Good thought. However, there's also a run-time dependency since
xfsrestore uses libhandle.so rather than the .a. I can rework something
using dlsym - sound okay?

Bill

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-10-27 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22 16:52 [PATCH 2/2] use lpath_to_handle when restoring symlinks Bill Kendall
2009-10-23 18:13 ` Alex Elder
2009-10-25  7:05 ` Christoph Hellwig
2009-10-27 15:36   ` Bill Kendall [this message]
2009-10-28  3:34     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE71364.7090102@sgi.com \
    --to=wkendall@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox