From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] libdisk: do not install libdisk.a
Date: Wed, 18 Nov 2009 22:08:15 -0600 [thread overview]
Message-ID: <4B04C4AF.50501@sandeen.net> (raw)
In-Reply-To: <20091030131517.GB18462@infradead.org>
Christoph Hellwig wrote:
> Since xfsprogs 3.0 libdisk is intended to be private to xfsprogs and we do
> not install the headers anymore. But we kept installing the static library,
> which doesn't make sense.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
>
> Index: xfsprogs-dev/libdisk/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/libdisk/Makefile 2009-10-30 13:12:03.000000000 +0000
> +++ xfsprogs-dev/libdisk/Makefile 2009-10-30 13:12:08.000000000 +0000
> @@ -27,6 +27,5 @@ include $(BUILDRULES)
> install: default
>
> install-dev: default
> - $(INSTALL_LTLIB_STATIC)
>
> install-qa: install-dev
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-11-19 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 13:15 [PATCH] libdisk: do not install libdisk.a Christoph Hellwig
2009-11-19 4:08 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04C4AF.50501@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox