public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libdisk: do not install libdisk.a
@ 2009-10-30 13:15 Christoph Hellwig
  2009-11-19  4:08 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-10-30 13:15 UTC (permalink / raw)
  To: xfs

Since xfsprogs 3.0 libdisk is intended to be private to xfsprogs and we do
not install the headers anymore.  But we kept installing the static library,
which doesn't make sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfsprogs-dev/libdisk/Makefile
===================================================================
--- xfsprogs-dev.orig/libdisk/Makefile	2009-10-30 13:12:03.000000000 +0000
+++ xfsprogs-dev/libdisk/Makefile	2009-10-30 13:12:08.000000000 +0000
@@ -27,6 +27,5 @@ include $(BUILDRULES)
 install: default
 
 install-dev: default
-	$(INSTALL_LTLIB_STATIC)
 
 install-qa: install-dev

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libdisk: do not install libdisk.a
  2009-10-30 13:15 [PATCH] libdisk: do not install libdisk.a Christoph Hellwig
@ 2009-11-19  4:08 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2009-11-19  4:08 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

Christoph Hellwig wrote:
> Since xfsprogs 3.0 libdisk is intended to be private to xfsprogs and we do
> not install the headers anymore.  But we kept installing the static library,
> which doesn't make sense.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

> 
> Index: xfsprogs-dev/libdisk/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/libdisk/Makefile	2009-10-30 13:12:03.000000000 +0000
> +++ xfsprogs-dev/libdisk/Makefile	2009-10-30 13:12:08.000000000 +0000
> @@ -27,6 +27,5 @@ include $(BUILDRULES)
>  install: default
>  
>  install-dev: default
> -	$(INSTALL_LTLIB_STATIC)
>  
>  install-qa: install-dev
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-19  4:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-30 13:15 [PATCH] libdisk: do not install libdisk.a Christoph Hellwig
2009-11-19  4:08 ` Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox