From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/7] xfs: remove IO_ISAIO
Date: Wed, 18 Nov 2009 22:36:36 -0600 [thread overview]
Message-ID: <4B04CB54.9060308@sandeen.net> (raw)
In-Reply-To: <20091114161801.238873282@bombadil.infradead.org>
Christoph Hellwig wrote:
Looks fine to me.
> We set this flag for all read/write I/O since early Linux 2.6.x.
> Remove it as it has lost it's purpose long ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfs/fs/xfs/linux-2.6/xfs_file.c
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_file.c 2009-10-11 14:25:17.496003686 +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_file.c 2009-11-12 17:14:06.160023109 +0100
> @@ -52,7 +52,7 @@ xfs_file_aio_read(
> loff_t pos)
> {
> struct file *file = iocb->ki_filp;
> - int ioflags = IO_ISAIO;
> + int ioflags = 0;
>
> BUG_ON(iocb->ki_pos != pos);
> if (unlikely(file->f_flags & O_DIRECT))
> @@ -71,7 +71,7 @@ xfs_file_aio_write(
> loff_t pos)
> {
> struct file *file = iocb->ki_filp;
> - int ioflags = IO_ISAIO;
> + int ioflags = 0;
>
> BUG_ON(iocb->ki_pos != pos);
> if (unlikely(file->f_flags & O_DIRECT))
> Index: xfs/fs/xfs/linux-2.6/xfs_lrw.c
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_lrw.c 2009-11-12 17:10:19.909278501 +0100
> +++ xfs/fs/xfs/linux-2.6/xfs_lrw.c 2009-11-12 17:14:06.161003891 +0100
> @@ -255,8 +255,6 @@ xfs_read(
>
> iocb->ki_pos = *offset;
> ret = generic_file_aio_read(iocb, iovp, segs, *offset);
> - if (ret == -EIOCBQUEUED && !(ioflags & IO_ISAIO))
> - ret = wait_on_sync_kiocb(iocb);
> if (ret > 0)
> XFS_STATS_ADD(xs_read_bytes, ret);
>
> @@ -774,9 +772,6 @@ write_retry:
>
> current->backing_dev_info = NULL;
>
> - if (ret == -EIOCBQUEUED && !(ioflags & IO_ISAIO))
> - ret = wait_on_sync_kiocb(iocb);
> -
> isize = i_size_read(inode);
> if (unlikely(ret < 0 && ret != -EFAULT && *offset > isize))
> *offset = isize;
> Index: xfs/fs/xfs/linux-2.6/xfs_vnode.h
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_vnode.h 2009-11-12 17:10:19.942276910 +0100
> +++ xfs/fs/xfs/linux-2.6/xfs_vnode.h 2009-11-12 17:14:06.161003891 +0100
> @@ -36,7 +36,6 @@ struct attrlist_cursor_kern;
> /*
> * Flags for read/write calls - same values as IRIX
> */
> -#define IO_ISAIO 0x00001 /* don't wait for completion */
> #define IO_ISDIRECT 0x00004 /* bypass page cache */
> #define IO_INVIS 0x00020 /* don't update inode timestamps */
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-19 4:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 16:17 [PATCH 0/7] assorted cleanups Christoph Hellwig
2009-11-14 16:17 ` [PATCH 1/7] xfs: remove IO_ISAIO Christoph Hellwig
2009-11-16 3:05 ` Dave Chinner
2009-11-19 4:36 ` Eric Sandeen [this message]
2009-11-14 16:17 ` [PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read Christoph Hellwig
2009-11-16 3:15 ` Dave Chinner
2009-11-16 11:03 ` Christoph Hellwig
2009-11-19 4:40 ` Eric Sandeen
2009-11-24 18:02 ` [PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces Christoph Hellwig
2009-11-25 0:16 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int Christoph Hellwig
2009-11-16 3:17 ` Dave Chinner
2009-11-19 4:42 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 4/7] xfs: uninline xfs_get_extsz_hint Christoph Hellwig
2009-11-16 3:18 ` Dave Chinner
2009-11-19 4:51 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 5/7] xfs: kill the STATIC_INLINE macro Christoph Hellwig
2009-11-16 3:20 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 6/7] xfs: remove incorrect sparse annotation for xfs_iget_cache_miss Christoph Hellwig
2009-11-16 3:22 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 7/7] xfs: cleanup dmapi macros in the umount path Christoph Hellwig
2009-11-16 3:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04CB54.9060308@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox