From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int
Date: Wed, 18 Nov 2009 22:42:53 -0600 [thread overview]
Message-ID: <4B04CCCD.4020206@sandeen.net> (raw)
In-Reply-To: <20091114161801.612419979@bombadil.infradead.org>
Christoph Hellwig wrote:
> Using a totally different name for the lowlevel get operation does not
> fit the _int convention used in the rest of the attr code, so rename it.
>
> While we're at it also fix the prototype to use the normal convention
> and mark it static as it's never used outside of xfs_attr.c.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfs/fs/xfs/xfs_attr.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_attr.c 2009-11-12 17:10:20.047264798 +0100
> +++ xfs/fs/xfs/xfs_attr.c 2009-11-12 17:18:17.703273473 +0100
> @@ -123,9 +123,13 @@ xfs_inode_hasattr(
> * Overall external interface routines.
> *========================================================================*/
>
> -int
> -xfs_attr_fetch(xfs_inode_t *ip, struct xfs_name *name,
> - char *value, int *valuelenp, int flags)
> +STATIC int
> +xfs_attr_get_int(
> + struct xfs_inode *ip,
> + struct xfs_name *name,
> + char *value,
> + int *valuelenp,
> + int flags)
> {
> xfs_da_args_t args;
> int error;
> @@ -188,7 +192,7 @@ xfs_attr_get(
> return error;
>
> xfs_ilock(ip, XFS_ILOCK_SHARED);
> - error = xfs_attr_fetch(ip, &xname, value, valuelenp, flags);
> + error = xfs_attr_get_int(ip, &xname, value, valuelenp, flags);
> xfs_iunlock(ip, XFS_ILOCK_SHARED);
> return(error);
> }
> Index: xfs/fs/xfs/xfs_attr.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_attr.h 2009-11-12 17:10:20.056254911 +0100
> +++ xfs/fs/xfs/xfs_attr.h 2009-11-12 17:18:17.703273473 +0100
> @@ -131,7 +131,6 @@ typedef struct xfs_attr_list_context {
> */
> int xfs_attr_calc_size(struct xfs_inode *, int, int, int *);
> int xfs_attr_inactive(struct xfs_inode *dp);
> -int xfs_attr_fetch(struct xfs_inode *, struct xfs_name *, char *, int *, int);
> int xfs_attr_rmtval_get(struct xfs_da_args *args);
> int xfs_attr_list_int(struct xfs_attr_list_context *);
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-19 4:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 16:17 [PATCH 0/7] assorted cleanups Christoph Hellwig
2009-11-14 16:17 ` [PATCH 1/7] xfs: remove IO_ISAIO Christoph Hellwig
2009-11-16 3:05 ` Dave Chinner
2009-11-19 4:36 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read Christoph Hellwig
2009-11-16 3:15 ` Dave Chinner
2009-11-16 11:03 ` Christoph Hellwig
2009-11-19 4:40 ` Eric Sandeen
2009-11-24 18:02 ` [PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces Christoph Hellwig
2009-11-25 0:16 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int Christoph Hellwig
2009-11-16 3:17 ` Dave Chinner
2009-11-19 4:42 ` Eric Sandeen [this message]
2009-11-14 16:17 ` [PATCH 4/7] xfs: uninline xfs_get_extsz_hint Christoph Hellwig
2009-11-16 3:18 ` Dave Chinner
2009-11-19 4:51 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 5/7] xfs: kill the STATIC_INLINE macro Christoph Hellwig
2009-11-16 3:20 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 6/7] xfs: remove incorrect sparse annotation for xfs_iget_cache_miss Christoph Hellwig
2009-11-16 3:22 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 7/7] xfs: cleanup dmapi macros in the umount path Christoph Hellwig
2009-11-16 3:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04CCCD.4020206@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox