From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: make several more functions static
Date: Fri, 20 Nov 2009 09:32:48 -0600 [thread overview]
Message-ID: <4B06B6A0.3030908@sandeen.net> (raw)
In-Reply-To: <20091120063720.GA3804@discord.disaster>
Dave Chinner wrote:
> On Thu, Nov 19, 2009 at 09:52:00AM -0600, Eric Sandeen wrote:
>> Just minor housekeeping, a lot more functions can be trivially
>> made static; others could if we reordered things a bit...
>
> Only one minor comment:
>
>> -void
>> +STATIC_INLINE void
>> xlog_put_bp(
>> xfs_buf_t *bp)
>> {
>
> I'd change that as STATIC as Christoph's recent patch removed
> STATIC_INLINE. gcc will inline it for us if it's a win....
Oops, ok, thanks for looking at it.
-Eric
> Cheers,
>
> Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-11-20 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 15:52 [PATCH] xfs: make several more functions static Eric Sandeen
2009-11-20 6:37 ` Dave Chinner
2009-11-20 15:32 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B06B6A0.3030908@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox