public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 213: Add enospc case to fallocate test
Date: Wed, 25 Nov 2009 15:36:10 -0600	[thread overview]
Message-ID: <4B0DA34A.1030400@redhat.com> (raw)
In-Reply-To: <20091125210731.GB12150@infradead.org>

Christoph Hellwig wrote:
> On Wed, Nov 25, 2009 at 11:18:47AM -0600, Eric Sandeen wrote:
>> Add a test for ENOSPC when fallocating.
>>
>> Also, add an expected output, not sure how that went missing!
> 
> Oops.  Easily to do because xfstests doesn't complain but rather just
> skips tests without golden output..
> 
> I guess the ENOSPC test is to catch the inverted error returns just
> detected?

yep

> Anyway, looks good,

thanks!

-eric

> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-11-25 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 17:18 [PATCH] xfstests 213: Add enospc case to fallocate test Eric Sandeen
2009-11-25 21:07 ` Christoph Hellwig
2009-11-25 21:36   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0DA34A.1030400@redhat.com \
    --to=sandeen@redhat.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox