From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_db: modify bad_features2 when modifying features2
Date: Tue, 01 Dec 2009 13:17:55 -0600 [thread overview]
Message-ID: <4B156BE3.2080107@sandeen.net> (raw)
The "attr1" command in xfs_db, for example, only modifies the features2
field; when mounted, the kernel will find a mismatch between features2
and bad_features2, and attr2 gets turned back on.
I think the simplest fix is to modify do_version to modify both fields,
but not if there is an existing mismatch that should be investigated
first.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/db/sb.c b/db/sb.c
index 7c61b15..961a939 100644
--- a/db/sb.c
+++ b/db/sb.c
@@ -556,6 +556,12 @@ do_version(xfs_agnumber_t agno, __uint16_t version, __uint32_t features)
if (!get_sb(agno, &tsb))
return 0;
+ if (xfs_sb_has_mismatched_features2(&tsb)) {
+ dbprintf(_("Superblock has mismatched features2 fields, "
+ "skipping modification\n"));
+ return 0;
+ }
+
if ((version & XFS_SB_VERSION_LOGV2BIT) &&
!xfs_sb_version_haslogv2(&tsb)) {
tsb.sb_logsunit = 1;
@@ -564,7 +570,8 @@ do_version(xfs_agnumber_t agno, __uint16_t version, __uint32_t features)
tsb.sb_versionnum = version;
tsb.sb_features2 = features;
- fields |= XFS_SB_VERSIONNUM | XFS_SB_FEATURES2;
+ tsb.sb_bad_features2 = features;
+ fields |= XFS_SB_VERSIONNUM | XFS_SB_FEATURES2 | XFS_SB_BAD_FEATURES2;
libxfs_sb_to_disk(iocur_top->data, &tsb, fields);
write_cur();
return 1;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-12-01 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 19:17 Eric Sandeen [this message]
2009-12-02 15:04 ` [PATCH] xfs_db: modify bad_features2 when modifying features2 Christoph Hellwig
2009-12-02 15:19 ` Eric Sandeen
2009-12-02 15:40 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B156BE3.2080107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox