public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] (resend) xfsprogs: make lazy-count=1 the default.
@ 2009-12-01 19:34 Eric Sandeen
  2009-12-02 15:10 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2009-12-01 19:34 UTC (permalink / raw)
  To: xfs-oss

With the xfstests fixed up, we should be able to do this now.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Index: xfsprogs-2.10.2/mkfs/xfs_mkfs.c
===================================================================
--- xfsprogs-2.10.2.orig/mkfs/xfs_mkfs.c
+++ xfsprogs-2.10.2/mkfs/xfs_mkfs.c
@@ -733,7 +733,7 @@ main(
 	nodsflag = norsflag = 0;
 	force_overwrite = 0;
 	worst_freelist = 0;
-	lazy_sb_counters = 0;
+	lazy_sb_counters = 1;
 	memset(&fsx, 0, sizeof(fsx));
 
 	memset(&xi, 0, sizeof(xi));
Index: xfsprogs-2.10.2/man/man8/mkfs.xfs.8
===================================================================
--- xfsprogs-2.10.2.orig/man/man8/mkfs.xfs.8
+++ xfsprogs-2.10.2/man/man8/mkfs.xfs.8
@@ -455,9 +455,10 @@ counter values without needed to keep th
 This gives significant improvements in performance on some configurations.
 The default
 .I value
-is 0 (off) so you must specify
-.B lazy-count=1
-if you want to make use of this feature.
+is 1 (on) so you must specify
+.B lazy-count=0
+if you want to disable this feature for older kernels which don't support
+it.
 .RE
 .TP
 .BI \-n " naming_options"

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] (resend) xfsprogs: make lazy-count=1 the default.
  2009-12-01 19:34 [PATCH] (resend) xfsprogs: make lazy-count=1 the default Eric Sandeen
@ 2009-12-02 15:10 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2009-12-02 15:10 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Tue, Dec 01, 2009 at 01:34:27PM -0600, Eric Sandeen wrote:
> With the xfstests fixed up, we should be able to do this now.

Thanks, this is long overdue and a good default for 3.1.0.

We should announce it prominently enough in CHANGES and the release
mail, though.


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-02 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 19:34 [PATCH] (resend) xfsprogs: make lazy-count=1 the default Eric Sandeen
2009-12-02 15:10 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox