Re: [PATCH] db: stop using xfs_bmbt_rec_32_t

Christoph Hellwig
2009-12-04T10:03:33Z

On Wed, Dec 02, 2009 at 11:37:44AM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > xfs_db uses the xfs_bmbt_rec_32_t type to pass around extent information in a
> > few places. But everywhere where we actually use it we use the normal
> > xfs_bmbt_rec_t just casting from/to xfs_bmbt_rec_32_t to pass it around.
> >
> > Just pass the xfs_bmbt_rec_t directly and thus get rid of the last use
> > of xfs_bmbt_rec_32_t in xfsprogs.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Seems fine.
>
> After this should the db references to xfs_bmbt_rec_64_t be
> changed to xfs_bmbt_rec_t perhaps?

Yes, except that we don't actually have the struct type for it yet which
we'll need in at least one place. I'll do it once I've removed the _32
and _64 types in the kernel and synced over the changes to userspace.