[PATCH] xfs_io: enable missing functions

[PATCH] xfs_io: enable missing functions

[Eric Sandeen]

madvise and mincore were never hooked up to init_commands().

Further, there is no HAVE_INJECT test in the configure scripts,
so just remove that test (and keep the existing unconditional
inject_init() prototype.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/io/init.c b/io/init.c
index 6539a55..f8fc25d 100644
--- a/io/init.c
+++ b/io/init.c
@@ -64,6 +64,8 @@ init_commands(void)
 	help_init();
 	imap_init();
 	inject_init();
+	madvise_init();
+	mincore_init();
 	mmap_init();
 	open_init();
 	parent_init();
diff --git a/io/io.h b/io/io.h
index 43754ca..630897d 100644
--- a/io/io.h
+++ b/io/io.h
@@ -112,12 +112,6 @@ extern void		fadvise_init(void);
 #define fadvise_init()	do { } while (0)
 #endif
 
-#ifdef HAVE_INJECT
-extern void		inject_init(void);
-#else
-#define inject_init()	do { } while (0)
-#endif
-
 #ifdef HAVE_RESBLKS
 extern void		resblks_init(void);
 #else

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: enable missing functions

[Christoph Hellwig]

On Wed, Dec 02, 2009 at 12:13:56PM -0600, Eric Sandeen wrote:
> madvise and mincore were never hooked up to init_commands().
> 
> Further, there is no HAVE_INJECT test in the configure scripts,
> so just remove that test (and keep the existing unconditional
> inject_init() prototype.

Hmm, maybe Nathan still has an idea what it's for, probably some IRIX
build.

Anyway, the madvise and mincore wireup looks good.  Note entirely sure
what they do in xfs_io, though - they're VM syscalls not filesystem and
don't cause I/O normally.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs