[PATCH] xfs_io: update bmap help text

[PATCH] xfs_io: update bmap help text

[Eric Sandeen]

Trivial addition of missing argument help text.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

iff --git a/io/bmap.c b/io/bmap.c
index f79cf8c..5c4cf48 100644
--- a/io/bmap.c
+++ b/io/bmap.c
@@ -43,6 +43,9 @@ bmap_help(void)
 " -a -- prints the attribute fork map instead of the data fork.\n"
 " -d -- suppresses a DMAPI read event, offline portions shown as holes.\n"
 " -l -- also displays the length of each extent in 512-byte blocks.\n"
+" -n -- query n extents.\n"
+" -p -- obtain all unwritten extents as well (w/ -v show which are unwritten.\n"
+" -v -- Verbose information, specify ag info.  Show flags legend on 2nd -v\n"
 " Note: the bmap for non-regular files can be obtained provided the file\n"
 " was opened appropriately (in particular, must be opened read-only).\n"
 "\n"));

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: update bmap help text

[Dave Chinner]

On Thu, Dec 10, 2009 at 04:01:51PM -0600, Eric Sandeen wrote:
> Trivial addition of missing argument help text.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> iff --git a/io/bmap.c b/io/bmap.c
> index f79cf8c..5c4cf48 100644
> --- a/io/bmap.c
> +++ b/io/bmap.c
> @@ -43,6 +43,9 @@ bmap_help(void)
>  " -a -- prints the attribute fork map instead of the data fork.\n"
>  " -d -- suppresses a DMAPI read event, offline portions shown as holes.\n"
>  " -l -- also displays the length of each extent in 512-byte blocks.\n"
> +" -n -- query n extents.\n"
> +" -p -- obtain all unwritten extents as well (w/ -v show which are unwritten.\n"

Closing ')"?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: update bmap help text

[Eric Sandeen]

Dave Chinner wrote:
> On Thu, Dec 10, 2009 at 04:01:51PM -0600, Eric Sandeen wrote:
>> Trivial addition of missing argument help text.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>> ---
>>
>> iff --git a/io/bmap.c b/io/bmap.c
>> index f79cf8c..5c4cf48 100644
>> --- a/io/bmap.c
>> +++ b/io/bmap.c
>> @@ -43,6 +43,9 @@ bmap_help(void)
>>  " -a -- prints the attribute fork map instead of the data fork.\n"
>>  " -d -- suppresses a DMAPI read event, offline portions shown as holes.\n"
>>  " -l -- also displays the length of each extent in 512-byte blocks.\n"
>> +" -n -- query n extents.\n"
>> +" -p -- obtain all unwritten extents as well (w/ -v show which are unwritten.\n"
> 
> Closing ')"?

details details!  ;)  And with that I have your review? :)

Thanks,
-Eric

> Cheers,
> 
> Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_io: update bmap help text

[Christoph Hellwig]

On Thu, Dec 10, 2009 at 04:01:51PM -0600, Eric Sandeen wrote:
> Trivial addition of missing argument help text.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> iff --git a/io/bmap.c b/io/bmap.c
> index f79cf8c..5c4cf48 100644
> --- a/io/bmap.c
> +++ b/io/bmap.c
> @@ -43,6 +43,9 @@ bmap_help(void)
>  " -a -- prints the attribute fork map instead of the data fork.\n"
>  " -d -- suppresses a DMAPI read event, offline portions shown as holes.\n"
>  " -l -- also displays the length of each extent in 512-byte blocks.\n"
> +" -n -- query n extents.\n"
> +" -p -- obtain all unwritten extents as well (w/ -v show which are unwritten.\n"
> +" -v -- Verbose information, specify ag info.  Show flags legend on 2nd -v\n"

Looks good modulo the missing brace as noted by Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs