From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o04NHMqn154674 for ; Mon, 4 Jan 2010 17:17:23 -0600 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BEAF211EE87D for ; Mon, 4 Jan 2010 15:18:12 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id EqEVzEB3dCXGIbfe for ; Mon, 04 Jan 2010 15:18:12 -0800 (PST) Message-ID: <4B427731.9080801@redhat.com> Date: Mon, 04 Jan 2010 17:18:09 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: [PATCH] xfstests: add another fallocate test to 214 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs mailing list , ext4 development Cc: Theodore Tso ext4 had a regression where it double-accounted used blocks if you fallocated on top of delalloc blocks. Ted sent a c program to exploit it (see "fsstress-induced corruption reproduced" on linux-ext4 on 12/31/2009) and it's trivial to do the same thing within the xfstests framework using xfs_io. This also changes the handcrafted xfs_io tests to use the _require_xfs_io_falloc helper, not sure how that got missed. Signed-off-by: Eric Sandeen --- diff --git a/214 b/214 index 98cfc3a..35ec2cb 100755 --- a/214 +++ b/214 @@ -52,14 +52,7 @@ _supported_os Linux rm -f $seq.full -testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1` - -# Old xfs_io doesn't have fallocate support -echo $testio | grep -q "not found" && \ - _notrun "xfs_io fallocate support is missing" -# Old glibc, old kernels, and some filesystems don't have fallocate support -echo $testio | grep -q "Operation not supported" && \ - _notrun "xfs_io fallocate command failed (old kernel? wrong fs?)" +_require_xfs_io_falloc # Ok, off we go. @@ -126,6 +119,20 @@ $XFS_IO_PROG -F -f -d \ rm -f $TEST_DIR/ouch +# Reported by Ted Ts'o on linux-ext4, 12/31/2009 +# double-allocation on ext4 when fallocating over delalloc blocks +# Regression due to d21cd8f163ac44b15c465aab7306db931c606908 + +echo "=== delalloc write 16k; fallocate same range ===" +# delalloc write 16k, fallocate same range. +# Should get caught on fsck when we're done. + +$XFS_IO_PROG -F -f \ + -c "pwrite 0 16k" \ + -c "falloc 0 16k" \ + -c "fsync" \ + $TEST_DIR/ouch2 | _filter_xfs_io_unique + # success, all done status=0 exit _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs