public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix up mkfs.gfs2 args for test 032
@ 2010-01-14 20:45 Eric Sandeen
  2010-01-15 17:50 ` Alex Elder
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2010-01-14 20:45 UTC (permalink / raw)
  To: xfs mailing list

Looks like gfs2 (recently?) needs more arguments for the
mkfs overwrite test.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/032 b/032
index f81196c..5db89ad 100755
--- a/032
+++ b/032
@@ -58,7 +58,7 @@ do
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
 	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
-	[ $fs = gfs2 ] && preop="echo y |"
+	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] xfstests: fix up mkfs.gfs2 args for test 032
  2010-01-14 20:45 [PATCH] xfstests: fix up mkfs.gfs2 args for test 032 Eric Sandeen
@ 2010-01-15 17:50 ` Alex Elder
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2010-01-15 17:50 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs mailing list

Eric Sandeen wrote:
> Looks like gfs2 (recently?) needs more arguments for the
> mkfs overwrite test.

Looks good.

> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---

Reviewed-by: Alex Elder <aelder@sgi.com>

> diff --git a/032 b/032
> index f81196c..5db89ad 100755
> --- a/032
> +++ b/032
> @@ -58,7 +58,7 @@ do
>  	# these folks prompt before writing
>  	[ $fs = jfs ] && preop="echo Y |"
>  	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
> -	[ $fs = gfs2 ] && preop="echo y |"
> +	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs/xfs
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-15 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 20:45 [PATCH] xfstests: fix up mkfs.gfs2 args for test 032 Eric Sandeen
2010-01-15 17:50 ` Alex Elder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox