* [PATCH] xfstests 073: unmount source image in cleanup
@ 2010-01-16 0:41 Eric Sandeen
2010-01-17 11:41 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2010-01-16 0:41 UTC (permalink / raw)
To: xfs-oss
Test 073 is currently failing w/ xfs_repair problems, and when
it does, the whole series stops because the test dir still has
a loopback mounted filesystem on it, and it can't unmount.
Fix that.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/073 b/073
index 0ef9287..756c1c8 100755
--- a/073
+++ b/073
@@ -44,6 +44,7 @@ _cleanup()
umount $SCRATCH_MNT 2>/dev/null
umount -d $imgs.loop 2>/dev/null
[ -d $imgs.loop ] && rmdir $imgs.loop
+ umount -d $imgs.source_dir 2>/dev/null
[ -d $imgs.source_dir ] && rm -rf $imgs.source_dir
rm -f $imgs.* $tmp.* /var/tmp/xfs_copy.log.*
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests 073: unmount source image in cleanup
2010-01-16 0:41 [PATCH] xfstests 073: unmount source image in cleanup Eric Sandeen
@ 2010-01-17 11:41 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2010-01-17 11:41 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Jan 15, 2010 at 06:41:37PM -0600, Eric Sandeen wrote:
> Test 073 is currently failing w/ xfs_repair problems, and when
> it does, the whole series stops because the test dir still has
> a loopback mounted filesystem on it, and it can't unmount.
>
> Fix that.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> diff --git a/073 b/073
> index 0ef9287..756c1c8 100755
> --- a/073
> +++ b/073
> @@ -44,6 +44,7 @@ _cleanup()
> umount $SCRATCH_MNT 2>/dev/null
> umount -d $imgs.loop 2>/dev/null
> [ -d $imgs.loop ] && rmdir $imgs.loop
> + umount -d $imgs.source_dir 2>/dev/null
> [ -d $imgs.source_dir ] && rm -rf $imgs.source_dir
> rm -f $imgs.* $tmp.* /var/tmp/xfs_copy.log.*
Yes, we should always unmount everything in the cleanup handler.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-17 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-16 0:41 [PATCH] xfstests 073: unmount source image in cleanup Eric Sandeen
2010-01-17 11:41 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox