From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Convert all tests to use /bin/bash
Date: Tue, 19 Jan 2010 17:37:25 -0600 [thread overview]
Message-ID: <4B564235.60403@sandeen.net> (raw)
In-Reply-To: <1263891633-30868-1-git-send-email-david@fromorbit.com>
Dave Chinner wrote:
> While most tests use /bin/sh, they are dependent on /bin/sh being a
> bash shell. Convert all the tests to execute via /bin/bash as it is
> much, much simpler than trying to debug and remove all the bashisms
> throughout the test code.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
well, spoke a little too soon.
OK as far as it goes, but not quite far enough :)
the "new" file still contains sh and I guess it could be used
as a template so maybe fix that up.
and do you care about things like:
| tee -a $here/$seq.full | sh
in 001?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-19 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 9:00 [PATCH] xfstests: Convert all tests to use /bin/bash Dave Chinner
2010-01-19 23:25 ` Eric Sandeen
2010-01-19 23:37 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B564235.60403@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox