public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: filter selinux output in _acl_ls
Date: Thu, 28 Jan 2010 17:34:36 -0600	[thread overview]
Message-ID: <4B621F0C.2070407@sandeen.net> (raw)
In-Reply-To: <4B61C1BC.4050800@sandeen.net>

Eric Sandeen wrote:
> When selinux is on, ls -l gives us a "." to indicate selinux
> attrs, which breaks some tests:
> 
>  === Test minimal ACE ===
>  Setup file
> --rwxrw-r-- id1 id2 file1
> +-rwxrw-r--. id1 id2 file1
> 
> so filter that out.

Hmm NAK this one for now; there are more places that need this
fixup, maybe an _ls_l() would be a good idea and put the filter
in one spot.

-Eric

> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> Index: xfstests/common.attr
> ===================================================================
> --- xfstests.orig/common.attr
> +++ xfstests/common.attr
> @@ -58,7 +58,10 @@ _acl_filter_id()
>  #
>  _acl_ls()
>  {
> -    ls -ln $* | awk '{ print $1, $3, $4, $NF }' | _acl_filter_id
> +    ls -ln $* |	\
> +    sed "s/\(.*\)\. /\1 /" | \
> +    awk '{ print $1, $3, $4, $NF }' | \
> +    _acl_filter_id
>  } 
>  
>  #
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-01-28 23:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 16:56 [PATCH] xfstests: filter selinux output in _acl_ls Eric Sandeen
2010-01-28 23:34 ` Eric Sandeen [this message]
2010-01-29  4:39 ` [PATCH V2] xfstests: filter selinux output in _acl_ls etc Eric Sandeen
2010-02-02 23:06   ` [PATCH V3] " Eric Sandeen
2010-02-03 10:56     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B621F0C.2070407@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox