Re: [PATCH] xfstests: filter selinux output in _acl_ls

Eric Sandeen
2010-01-28T23:33:31Z

Eric Sandeen wrote:
> When selinux is on, ls -l gives us a "." to indicate selinux
> attrs, which breaks some tests:
>
> === Test minimal ACE ===
> Setup file
> --rwxrw-r-- id1 id2 file1
> +-rwxrw-r--. id1 id2 file1
>
> so filter that out.

Hmm NAK this one for now; there are more places that need this
fixup, maybe an _ls_l() would be a good idea and put the filter
in one spot.

-Eric

> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> Index: xfstests/common.attr
> ===================================================================
> --- xfstests.orig/common.attr
> +++ xfstests/common.attr
> @@ -58,7 +58,10 @@ _acl_filter_id()
> #
> _acl_ls()
> {
> - ls -ln $* | awk '{ print $1, $3, $4, $NF }' | _acl_filter_id
> + ls -ln $* | \
> + sed "s/\(.*\)\. /\1 /" | \
> + awk '{ print $1, $3, $4, $NF }' | \
> + _acl_filter_id
> }
>
> #
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>