public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs mailing list <xfs@oss.sgi.com>
Subject: xfsprogs: to -DDEBUG or not to -DDEBUG?
Date: Thu, 04 Feb 2010 10:53:23 -0600	[thread overview]
Message-ID: <4B6AFB83.1070309@sandeen.net> (raw)

Fedora, long ago, disabled debug in the xfsprogs specfile:

http://cvs.fedoraproject.org/viewvc/F-12/xfsprogs/xfsprogs.spec?r1=1.5&r2=1.6

* Wed Apr 20 2005 Dave Jones <davej@redhat.com>
- Disable debug. (#151438)

per this bug:  https://bugzilla.redhat.com/show_bug.cgi?id=151438

referencing this email thread:

http://oss.sgi.com/archives/linux-xfs/2005-03/msg00038.html
which no longer exists (grrrr) but is probably now here:

http://oss.sgi.com/archives/xfs/2005-03/msg00416.html

Fedora still builds with -DNDEBUG, but the upstream tarball has
it on by default.  I have seen several occasions where other
distros had failing xfs_repairs which were "fixed" by disabling
debug.  I'd like to make a decision on whether DEBUG should be
on or off by default for upstream releases.  Any thoughts?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2010-02-04 16:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04 16:53 Eric Sandeen [this message]
2010-02-05  2:31 ` xfsprogs: to -DDEBUG or not to -DDEBUG? Dave Chinner
2010-02-05 21:14   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6AFB83.1070309@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox