* [PATCH] xfstests: make 204 generic
@ 2010-02-09 20:43 Eric Sandeen
2010-02-09 22:02 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2010-02-09 20:43 UTC (permalink / raw)
To: xfs-oss
204 can be generic.
Also remove a stray _scratch_mkfs that snuck into
_scratch_mkfs_sized :/
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/204 b/204
index 1ac9ebf..14ebcdc 100755
--- a/204
+++ b/204
@@ -35,12 +35,13 @@ status=1 # failure is the default!
. ./common.filter
# real QA test starts here
-_supported_fs xfs
+_supported_fs generic
_supported_os Linux
_require_scratch
-_scratch_mkfs_xfs -d size=104m >/dev/null
+SIZE=104*1024*1024
+_scratch_mkfs_sized $SIZE &> /dev/null
_scratch_mount
for i in `seq 1 22500`; do
diff --git a/common.rc b/common.rc
index 0a02a2b..c76bcde 100644
--- a/common.rc
+++ b/common.rc
@@ -325,7 +325,6 @@ _scratch_mkfs_sized()
_notrun "Filesystem $FSTYP not supported in _scratch_mkfs_sized"
;;
esac
- _scratch_mkfs
}
# Emulate an N-data-disk stripe w/ various stripe units
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfstests: make 204 generic
2010-02-09 20:43 [PATCH] xfstests: make 204 generic Eric Sandeen
@ 2010-02-09 22:02 ` Christoph Hellwig
2010-02-09 22:05 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-02-09 22:02 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Tue, Feb 09, 2010 at 02:43:11PM -0600, Eric Sandeen wrote:
> 204 can be generic.
Looks good.
> Also remove a stray _scratch_mkfs that snuck into
> _scratch_mkfs_sized :/
Heh, that might have made the ENOSPC tests pass rather easily before..
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: make 204 generic
2010-02-09 22:02 ` Christoph Hellwig
@ 2010-02-09 22:05 ` Eric Sandeen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2010-02-09 22:05 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs-oss
Christoph Hellwig wrote:
> On Tue, Feb 09, 2010 at 02:43:11PM -0600, Eric Sandeen wrote:
>> 204 can be generic.
>
> Looks good.
>
>> Also remove a stray _scratch_mkfs that snuck into
>> _scratch_mkfs_sized :/
>
> Heh, that might have made the ENOSPC tests pass rather easily before..
Yeah :/
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Thanks,
-eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-09 22:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 20:43 [PATCH] xfstests: make 204 generic Eric Sandeen
2010-02-09 22:02 ` Christoph Hellwig
2010-02-09 22:05 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox