[PATCH] xfstests: don't delete scratch loop device w/ umount -d

[PATCH] xfstests: don't delete scratch loop device w/ umount -d

[Eric Sandeen]

Recent fixes to 073 added umount -d, but if we happen
to be using a scratch device on loopback, subsequent
tests get very, very unhappy when their loopback block
device goes away!

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/073 b/073
index 90fa1f0..7ce6efb 100755
--- a/073
+++ b/073
@@ -119,7 +119,8 @@ _verify_copy()
 	diff -u $tmp.geometry1 $tmp.geometry2
 
 	echo unmounting and removing new image
-	umount -d $source_dir $target_dir
+	umount $source_dir
+	umount -d $target_dir
 	rm -f $target
 }
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: don't delete scratch loop device w/ umount -d

[Christoph Hellwig]

On Wed, Feb 17, 2010 at 02:29:38PM -0600, Eric Sandeen wrote:
> Recent fixes to 073 added umount -d, but if we happen
> to be using a scratch device on loopback, subsequent
> tests get very, very unhappy when their loopback block
> device goes away!

True, we only need -d for the loop devices created in the test.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs