public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests 125: don't traverse through fs for su command
Date: Thu, 18 Feb 2010 16:50:18 -0600	[thread overview]
Message-ID: <4B7DC42A.1030401@sandeen.net> (raw)

I often have xfstests in /root, and 125 fails for me like this:

--- 125.out	2009-08-05 20:19:40.380978986 -0500
+++ 125.out.bad	2010-02-18 16:48:57.507473627 -0600
@@ -1,4 +1,6 @@
 QA output created by 125
+bash: /root/git/xfstests-dev/src/ftrunc: Permission denied
+src/ftrunc returned non 0 status!
 direct write of 1's into file
 buffered write of 2's into file
 truncate file

I think this is becuase $here/src ... means going through
/root/git/xfstests-dev/src/ ... and the qa user can't
do that.

The below fixes it for me...

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/125 b/125
index e84109a..9a29941 100755
--- a/125
+++ b/125
@@ -61,7 +61,7 @@ touch $TESTFILE
 chmod a+rw $TESTDIR
 chmod a+rw $TESTFILE
 
-su $qa_user -c "$here/src/ftrunc -f $TESTFILE"
+su $qa_user -c "./src/ftrunc -f $TESTFILE"
 
 if [ "$?" != "0" ];  then
     echo src/ftrunc returned non 0 status!

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

                 reply	other threads:[~2010-02-18 22:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7DC42A.1030401@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox