public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix log filtering in 223's testcase
Date: Tue, 09 Mar 2010 11:58:22 -0600	[thread overview]
Message-ID: <4B968C3E.9000402@sandeen.net> (raw)
In-Reply-To: <876355pfrh.fsf@openvz.org>

Dmitry Monakhov wrote:
> Msg filter was missed in one place, so test failed if
> $SCRATCH_MNT is different than /mnt/scratch.diff 
> 
> Signed-off-by: Dimitry Monakhov <dmonakhov@openvz.org>

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

Whoops, yep!  Sorry.

I'll commit this shortly.

Thanks,
-Eric

> ---
>  223     |    3 ++-
>  223.out |   10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/223 b/223
> index 5c95f7d..7af026c 100755
> --- a/223
> +++ b/223
> @@ -86,7 +86,8 @@ for SUNIT_K in 8 16 32 64 128; do
>  
>  	echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
>  	xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
> -	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS
> +	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
> +	    | _filter_scratch
>  
>  	rm -f $SCRATCH_MNT/file-1g-falloc | _filter_scratch
>  
> diff --git a/223.out b/223.out
> index c9588ef..2fb3122 100644
> --- a/223.out
> +++ b/223.out
> @@ -46,7 +46,7 @@ SCRATCH_MNT/file-3-2097152-write: well-aligned
>  SCRATCH_MNT/file-4-2097152-falloc: well-aligned
>  SCRATCH_MNT/file-4-2097152-write: well-aligned
>  === Testing size 1g falloc on 8k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 8k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 4 blocks x 4 ===
> @@ -96,7 +96,7 @@ SCRATCH_MNT/file-3-4194304-write: well-aligned
>  SCRATCH_MNT/file-4-4194304-falloc: well-aligned
>  SCRATCH_MNT/file-4-4194304-write: well-aligned
>  === Testing size 1g falloc on 16k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 16k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 8 blocks x 4 ===
> @@ -146,7 +146,7 @@ SCRATCH_MNT/file-3-8388608-write: well-aligned
>  SCRATCH_MNT/file-4-8388608-falloc: well-aligned
>  SCRATCH_MNT/file-4-8388608-write: well-aligned
>  === Testing size 1g falloc on 32k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 32k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 16 blocks x 4 ===
> @@ -196,7 +196,7 @@ SCRATCH_MNT/file-3-16777216-write: well-aligned
>  SCRATCH_MNT/file-4-16777216-falloc: well-aligned
>  SCRATCH_MNT/file-4-16777216-write: well-aligned
>  === Testing size 1g falloc on 64k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 64k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 32 blocks x 4 ===
> @@ -246,6 +246,6 @@ SCRATCH_MNT/file-3-33554432-write: well-aligned
>  SCRATCH_MNT/file-4-33554432-falloc: well-aligned
>  SCRATCH_MNT/file-4-33554432-write: well-aligned
>  === Testing size 1g falloc on 128k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 128k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-03-09 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 17:27 [PATCH] xfstests: fix log filtering in 223's testcase Dmitry Monakhov
2010-03-09 17:58 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B968C3E.9000402@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=dmonakhov@openvz.org \
    --cc=hch@infradead.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox