[PATCH] xfstests: don't use -s option to repquota

[PATCH] xfstests: don't use -s option to repquota

[Christoph Hellwig]

The -s option to repquota used to be a no-op, but actually changes
output to different units in quota tools 4.0.  Remove it from the
repquota invocation in test 219.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/219
===================================================================
--- xfstests-dev.orig/219	2010-04-05 18:55:09.000000000 +0000
+++ xfstests-dev/219	2010-04-05 18:55:16.000000000 +0000
@@ -85,7 +85,7 @@ test_accounting()
 		$here/src/lstat64 $file | head -3 | filter_scratch
 	done
 
-	repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
+	repquota -$type -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
 	awk '/^#/ { if (seen[$1]) next; seen[$1]++; } { print; }'
 }
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: don't use -s option to repquota

[Eric Sandeen]

Christoph Hellwig wrote:
> The -s option to repquota used to be a no-op, but actually changes
> output to different units in quota tools 4.0.  Remove it from the
> repquota invocation in test 219.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, Ted was hitting this too.

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

> Index: xfstests-dev/219
> ===================================================================
> --- xfstests-dev.orig/219	2010-04-05 18:55:09.000000000 +0000
> +++ xfstests-dev/219	2010-04-05 18:55:16.000000000 +0000
> @@ -85,7 +85,7 @@ test_accounting()
>  		$here/src/lstat64 $file | head -3 | filter_scratch
>  	done
>  
> -	repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
> +	repquota -$type -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
>  	awk '/^#/ { if (seen[$1]) next; seen[$1]++; } { print; }'
>  }
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: don't use -s option to repquota

[tytso]

On Mon, Apr 05, 2010 at 02:40:23PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > The -s option to repquota used to be a no-op, but actually changes
> > output to different units in quota tools 4.0.  Remove it from the
> > repquota invocation in test 219.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Thanks, Ted was hitting this too.
> 
> Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

Thanks, I had submitting the patch on my todo list, and you just saved
me the effort of sending it.  :-)

I already had this change in my tree, and it works fine for me.

Tested-by: "Theodore Ts'o" <tytso@mit.edu>

							- Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs